Sign upLogin

scottwillson/racing_on_rails

View on GitHub
Star
app/helpers/results_helper.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method results_table has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def results_table(event, race, results = nil)
    return "" unless race

    table = Tabular::Table.new
Severity: Minor
Found in app/helpers/results_helper.rb - About 1 hr to fix

    Method results_table has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def results_table(event, race, results = nil)
    return "" unless race

    table = Tabular::Table.new
    Severity: Minor
    Found in app/helpers/results_helper.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

      # TODO: Move to module in Race?
    Severity: Minor
    Found in app/helpers/results_helper.rb by fixme

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if result.team_competition_result?
      css_class = "team results scores"
      table.row_mapper = Results::Mapper.new(%w[ place event_full_name race_name name event_date_range_s notes points ])
    else
      table.row_mapper = Results::Mapper.new(%w[ place event_full_name race_name event_date_range_s points ])
    Severity: Minor
    Found in app/helpers/results_helper.rb and 1 other location - About 25 mins to fix
    app/helpers/results_helper.rb on lines 114..118

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if result.team_competition_result?
      css_class = "team results scores"
      table.row_mapper = Results::Mapper.new(%w[ place event_full_name race_name name event_date_range_s notes points ])
    else
      table.row_mapper = Results::Mapper.new(%w[ place event_full_name race_name event_date_range_s points ])
    Severity: Minor
    Found in app/helpers/results_helper.rb and 1 other location - About 25 mins to fix
    app/helpers/results_helper.rb on lines 89..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status