Method best_match_in has a Cognitive Complexity of 83 (exceeds 5 allowed). Consider refactoring. Open
def best_match_in(event_categories, result_age = nil)
debug "Category#best_match_in for #{name} in #{event_categories.map(&:name).join(', ')}"
candidate_categories = event_categories.dup
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method best_match_in has 137 lines of code (exceeds 25 allowed). Consider refactoring. Open
def best_match_in(event_categories, result_age = nil)
debug "Category#best_match_in for #{name} in #{event_categories.map(&:name).join(', ')}"
candidate_categories = event_categories.dup
Method best_match_by_age_in has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def best_match_by_age_in(event_categories, result_age = nil)
debug "Category#best_match_by_age_in for #{name}, #{result_age} in #{event_categories.map(&:name).join(', ')}"
candidate_categories = event_categories.dup
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method best_match_by_age_in has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def best_match_by_age_in(event_categories, result_age = nil)
debug "Category#best_match_by_age_in for #{name}, #{result_age} in #{event_categories.map(&:name).join(', ')}"
candidate_categories = event_categories.dup
Consider simplifying this complex logical expression. Open
if candidate_categories.one? { |category| category.ability_begin == highest_ability && category.gender == gender && (!category.junior? || category.ages.size <= ages.size) }
highest_ability_category = candidate_categories.detect { |category| category.ability_begin == highest_ability && category.gender == gender && (!category.junior? || category.ages.size <= ages.size) }
debug "highest ability for gender: #{highest_ability_category.name}"
return highest_ability_category if highest_ability_category.include?(self)
endAvoid too many return statements within this method. Open
return candidate_categories.first if one_match?(candidate_categories)Avoid too many return statements within this method. Open
return junior_categories.first if junior_categories.one?Avoid too many return statements within this method. Open
return equipment_categories.first if equipment_categories.one?Avoid too many return statements within this method. Open
return nil if candidate_categories.empty?Avoid too many return statements within this method. Open
return nil if candidate_categories.empty?Avoid too many return statements within this method. Open
return candidate_categories.first if one_match?(candidate_categories)Avoid too many return statements within this method. Open
return candidate_categories.first if candidate_categories.one? && equipment?Avoid too many return statements within this method. Open
return candidate_categories.first if one_match?(candidate_categories)Avoid too many return statements within this method. Open
return candidate_categories.first if one_match?(candidate_categories)Avoid too many return statements within this method. Open
return candidate_categories.first if one_match?(candidate_categories)Avoid too many return statements within this method. Open
return candidate_categories.first if one_match?(candidate_categories)Avoid too many return statements within this method. Open
return nil if candidate_categories.empty?Avoid too many return statements within this method. Open
return highest_ability_category if highest_ability_category.include?(self)Avoid too many return statements within this method. Open
return ability_category if ability_category.include?(self)Avoid too many return statements within this method. Open
return masters_categories.first if masters_categories.one?Avoid too many return statements within this method. Open
return nilAvoid too many return statements within this method. Open
return nil if candidate_categories.empty?Avoid too many return statements within this method. Open
return highest_age_category if highest_age_category&.include?(self)Avoid too many return statements within this method. Open
return highest_senior_category if highest_senior_categoryAvoid too many return statements within this method. Open
return candidate_categories.first if one_match?(candidate_categories)Avoid too many return statements within this method. Open
return nil if candidate_categories.empty?Avoid too many return statements within this method. Open
return candidate_categories.first if one_match?(candidate_categories)Avoid too many return statements within this method. Open
return nil if candidate_categories.empty?Avoid too many return statements within this method. Open
return candidate_categories.first if candidate_categories.size == 1Avoid too many return statements within this method. Open
return candidate_categories.first if one_match?(candidate_categories)Avoid too many return statements within this method. Open
return nil if candidate_categories.empty?Avoid too many return statements within this method. Open
return highest_ability_category if highest_ability_category.include?(self)Method include? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def include?(other, result_age = nil)
return false unless other
abilities_include?(other) &&
ages_include?(other, result_age) &&- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
junior_categories = candidate_categories.select(&:junior?)
debug "junior: #{junior_categories.map(&:name).join(', ')}"
return junior_categories.first if junior_categories.one?
candidate_categories = junior_categories if junior_categories.present?- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 28.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
masters_categories = candidate_categories.select(&:masters?)
debug "masters?: #{masters_categories.map(&:name).join(', ')}"
return masters_categories.first if masters_categories.one?
candidate_categories = masters_categories if masters_categories.present?- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 28.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if candidate_categories.size > 1
raise "Multiple matches #{candidate_categories.map(&:name)} for #{name}, result age: #{result_age} in #{event_categories.map(&:name).join(', ')}"- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 26.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if candidate_categories.size > 1
raise "Multiple matches #{candidate_categories.map(&:name)} for #{name}, result age: #{result_age} in #{event_categories.map(&:name).join(', ')}"- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 26.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76