Sign upLogin

scottwillson/racing_on_rails

View on GitHub
Star
app/models/categories/name_normalization.rb

Summary

Maintainability
D
2 days
Test Coverage

Method normalize_spelling has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

      def self.normalize_spelling(name)
        if name
          name = name.split.map do |token|
            if token[/\A(cat|caat|categpry|categroy|cateogry|categegory|catgory|caegory|ct)\.?\z/i]
              "Category"
Severity: Minor
Found in app/models/categories/name_normalization.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method normalize_spelling has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.normalize_spelling(name)
        if name
          name = name.split.map do |token|
            if token[/\A(cat|caat|categpry|categroy|cateogry|categegory|catgory|caegory|ct)\.?\z/i]
              "Category"
Severity: Major
Found in app/models/categories/name_normalization.rb - About 3 hrs to fix

    File name_normalization.rb has 314 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Categories
  module NameNormalization
    extend ActiveSupport::Concern

    RACING_ASSOCIATIONS = %w[ ABA ATRA CBRA GBRA MBRA NABRA OBRA WSBA ].freeze
    Severity: Minor
    Found in app/models/categories/name_normalization.rb - About 3 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                  elsif token[/\Amaster\z/i] || token[/\Amas\z/i] || token[/\Amstr?\z/i] || token[/\Amaster's\z/i] ||
                  token[/\Amast.?\z/i] || token[/\Amaasters\z/i] || token[/\Amastes\z/i] || token[/\Amastres\z/i] ||
                  token[/\Amater\z/i] || token[/\Amaser\z/i] || token[/\Amst\z/i]

              "Masters"
      Severity: Critical
      Found in app/models/categories/name_normalization.rb - About 2 hrs to fix

        Method normalize_case has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

              def self.normalize_case(name)
        if name
          name = name.split.map do |token|
            # Calling RacingAssociation.current triggers an infinite loop
            if token[/of/i]
        Severity: Minor
        Found in app/models/categories/name_normalization.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method normalize_ability_punctuation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def self.normalize_ability_punctuation(name)
        # Don't combine Junior Men 9-12 3/4/5
        return name if name[%r{\d-1\d \d/\d/\d}]

        5.downto(2).each do |length|
        Severity: Minor
        Found in app/models/categories/name_normalization.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                    elsif token[/\Abeg?\.?\z/i] || token[/\Abg\.?\z/i] || token[/\Abegin?\.?\z/i] || token[/\Abeginners\z/i] || token[/\Abeg:\z/i] ||
                  token[/\ABeginning\z/i]

              "Beginner"
            elsif token[/\A(exp|expt|ex|exeprt|exb|exper|exprert)\.?\z/i]
        Severity: Major
        Found in app/models/categories/name_normalization.rb - About 40 mins to fix

          Method normalize_punctuation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.normalize_punctuation(name)
        if name
          # trailing punctuation
          name = name.gsub(%r{[/:.,"]\z}, "")
          Severity: Minor
          Found in app/models/categories/name_normalization.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method split_camelcase has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.split_camelcase(name)
        return name if name.nil?

        unless name.downcase == name || name.upcase == name
          name = name.gsub(/([A-Z\d]+)([A-Z][a-z])/, '\1 \2')
          Severity: Minor
          Found in app/models/categories/name_normalization.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method replace_roman_numeral_categories has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.replace_roman_numeral_categories(name)
        if name
          name = name.split.map do |token|
            case token
            when "I"
          Severity: Minor
          Found in app/models/categories/name_normalization.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  name.gsub(/junior m /i, "Junior Men ")
            .gsub(/Espior/i, "Espoir ")
            .gsub(/(\d+) (and|&) U\z/i, 'U\1')
            .gsub(/(\d+)& U\z/i, 'U\1')
            .gsub(/under (\d{2,3})/i, 'U\1')
          Severity: Minor
          Found in app/models/categories/name_normalization.rb and 1 other location - About 20 mins to fix
          app/models/categories/ability.rb on lines 82..91

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 28.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status