Sign upLogin

scottwillson/racing_on_rails

View on GitHub
Star
app/models/competitions/overall_bars/categories.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method equivalent_category_for has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def equivalent_category_for(category_friendly_param, discipline)
        return nil unless category_friendly_param && discipline

        if discipline == Discipline[:overall]
          event = self
Severity: Minor
Found in app/models/competitions/overall_bars/categories.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method categories_for has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def categories_for(race)
        categories = [race.category] + race.category.descendants

        if race.category.name == "Masters Men"
          masters_men_4_5 = ::Category.find_by(name: "Masters Men 4/5")
Severity: Minor
Found in app/models/competitions/overall_bars/categories.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status