Sign upLogin

scottwillson/racing_on_rails

View on GitHub
Star
app/models/people_file.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method import has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def import(update_membership, year = nil)
    ActiveSupport::Notifications.instrument(
      "import.people_file.racing_on_rails", update_membership: update_membership, import_file: import_file, rows: table.rows.size
    ) do
      @update_membership = update_membership
Severity: Minor
Found in app/models/people_file.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def import(update_membership, year = nil)
    ActiveSupport::Notifications.instrument(
      "import.people_file.racing_on_rails", update_membership: update_membership, import_file: import_file, rows: table.rows.size
    ) do
      @update_membership = update_membership
Severity: Minor
Found in app/models/people_file.rb - About 1 hr to fix

    Method assign_member_from_imported_people has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def assign_member_from_imported_people(year)
    if @update_membership
      @member_from_imported_people = if year && year > Time.zone.today.year
                                       Time.zone.local(year).beginning_of_year.to_date
                                     else
    Severity: Minor
    Found in app/models/people_file.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status