Sign upLogin

scottwillson/racing_on_rails

View on GitHub
Star
app/models/race_number.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method unique_number has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def unique_number
    _discipline = Discipline.find(discipline_id)
    if number_issuer.association? && RaceNumber.rental?(value, _discipline)
      errors.add("value", "#{value} is a rental number. #{RacingAssociation.current.short_name} rental numbers: #{RacingAssociation.current.rental_numbers}")
      person.errors.add("value", "#{value} is a rental number. #{RacingAssociation.current.short_name} rental numbers: #{RacingAssociation.current.rental_numbers}")
Severity: Minor
Found in app/models/race_number.rb - About 1 hr to fix

    Method unique_number has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def unique_number
    _discipline = Discipline.find(discipline_id)
    if number_issuer.association? && RaceNumber.rental?(value, _discipline)
      errors.add("value", "#{value} is a rental number. #{RacingAssociation.current.short_name} rental numbers: #{RacingAssociation.current.rental_numbers}")
      person.errors.add("value", "#{value} is a rental number. #{RacingAssociation.current.short_name} rental numbers: #{RacingAssociation.current.rental_numbers}")
    Severity: Minor
    Found in app/models/race_number.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

        return true if RacingAssociation.current.rental_numbers.include?(numeric_value)
    Severity: Major
    Found in app/models/race_number.rb - About 30 mins to fix

      Method rental? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.rental?(number, discipline = Discipline[:road])
    return false if RacingAssociation.current.rental_numbers.nil?

    return true if number.blank?
      Severity: Minor
      Found in app/models/race_number.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status