scottwillson/racing_on_rails

View on GitHub
test/controllers/admin/results_controller_test.rb

Summary

Maintainability
C
1 day
Test Coverage

File results_controller_test.rb has 423 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require File.expand_path("../../test_helper", __dir__)

module Admin
  # :stopdoc:
  class ResultsControllerTest < ActionController::TestCase
Severity: Minor
Found in test/controllers/admin/results_controller_test.rb - About 6 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        test "update no person to existing" do
          result = FactoryBot.create(:result, person: nil)
          tonkin = FactoryBot.create(:person, first_name: "Erik", last_name: "Tonkin")
          tonkin.aliases.create!(name: "Eric Tonkin")
          original_team_name = result.team_name
    Severity: Major
    Found in test/controllers/admin/results_controller_test.rb and 1 other location - About 1 hr to fix
    test/controllers/admin/results_controller_test.rb on lines 206..226

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        test "update no person to alias" do
          result = FactoryBot.create(:result, person: nil)
          tonkin = FactoryBot.create(:person, first_name: "Erik", last_name: "Tonkin")
          tonkin.aliases.create!(name: "Eric Tonkin")
    
    
    Severity: Major
    Found in test/controllers/admin/results_controller_test.rb and 1 other location - About 1 hr to fix
    test/controllers/admin/results_controller_test.rb on lines 184..203

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        test "update to new team" do
          result = FactoryBot.create(:result, team: nil)
    
          put :update_attribute,
              xhr: true,
    Severity: Minor
    Found in test/controllers/admin/results_controller_test.rb and 1 other location - About 35 mins to fix
    test/controllers/admin/results_controller_test.rb on lines 47..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        test "update no team to new" do
          result = FactoryBot.create(:result, team: nil)
    
          put :update_attribute,
              xhr: true,
    Severity: Minor
    Found in test/controllers/admin/results_controller_test.rb and 1 other location - About 35 mins to fix
    test/controllers/admin/results_controller_test.rb on lines 114..127

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status