Sign upLogin

scottwillson/racing_on_rails

View on GitHub
Star
test/controllers/admin/teams_controller_test.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File teams_controller_test.rb has 368 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require File.expand_path("../../test_helper", __dir__)

module Admin
  # :stopdoc:
  class TeamsControllerTest < ActionController::TestCase
Severity: Minor
Found in test/controllers/admin/teams_controller_test.rb - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        test "set name same name" do
      vanilla = FactoryBot.create(:team, name: "Vanilla Bicycles")
      put :update_attribute,
          params: {
            id: vanilla.to_param,
    Severity: Minor
    Found in test/controllers/admin/teams_controller_test.rb and 1 other location - About 1 hr to fix
    test/controllers/admin/teams_controller_test.rb on lines 146..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        test "set name same name different case" do
      vanilla = FactoryBot.create(:team, name: "Vanilla Bicycles")
      put :update_attribute,
          params: {
            id: vanilla.to_param,
    Severity: Minor
    Found in test/controllers/admin/teams_controller_test.rb and 1 other location - About 1 hr to fix
    test/controllers/admin/teams_controller_test.rb on lines 129..143

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status