scottwillson/racing_on_rails

File results_file_test.rb has 602 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "test_helper"

# :stopdoc:
module Results
  # FIXME: DNF's not handled correctly.

Method get_expected_races has 118 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def get_expected_races
      races = []

      race = Race.new(category: Category.new(name: "Senior Men Pro/1/2/3"))
      race.results << Result.new(place: "1", first_name: "Evan", last_name: "Elken", number: "154", license: "999999999", team_name: "Jittery Joe's", points: "23.0")

Method expected_results has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def expected_results(_event)
      expected_races = []

      race = Race.new(category: Category.new(name: "Category 3"))

Method build_result has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def build_result(race, place, first_name = nil, last_name = nil, team_name = nil)

TODO found

Open

      # TODO: Import starters/field size

• Exclude checks
  • Disable engine
  • Disable check

FIXME found

Open

  # FIXME: DNF's not handled correctly.

• Exclude checks
  • Disable engine
  • Disable check

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    test "#same_time?" do
      table = Tabular::Table.new([
                                   { place: "1", name: "Joanne Eastwood", time: "24:21" },
                                   { place: "2", name: "Nicole Pressprich", time: "" }
                                 ])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    test "#same_time? should consider place" do
      table = Tabular::Table.new([
                                   { place: "1", name: "Joanne Eastwood", time: "24:21" },
                                   { place: "DNS", name: "Nicole Pressprich", time: "DNS" }
                                 ])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            assert(result.person.member?(race_date), "member? for race #{index} result #{result_index} #{result.name} #{result.person.member_from} #{result.person.member_to}")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    test "race notes" do
      event = SingleDayEvent.create!
      results_file = ResultsFile.new(File.new(file_fixture("results/tt.xlsx")), event)
      results_file.import
      assert_equal("Field Size: 40 riders, 40 Laps, Sunny, cool, 40K", event.races.reload.first.notes, "Race notes")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            assert_not(result.person.member?(race_date), "member? for race #{index} result #{result_index} #{result.name} #{result.person.member_from} #{result.person.member_to}")

• Read up
  Read up