Sign upLogin

scottwillson/racing_on_rails

View on GitHub
Star
test_ruby/models/competitions/calculations/teams_test.rb

Summary

Maintainability
C
1 day
Test Coverage

Method test_apply_team_sizes_not_team_event_small_event has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def test_apply_team_sizes_not_team_event_small_event
        expected = [
          result(place: 1, race_id: 1, team_size: 3, participant_id: 1, field_size: 3),
          result(place: 1, race_id: 1, team_size: 3, participant_id: 2, field_size: 3),
          result(place: 1, race_id: 1, team_size: 3, participant_id: 3, field_size: 3)
Severity: Minor
Found in test_ruby/models/competitions/calculations/teams_test.rb - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            expected = [
          result(place: 1, race_id: 1, team_size: 1, participant_id: 1, field_size: 5),
          result(place: 2, race_id: 1, team_size: 1, participant_id: 2, field_size: 5),
          result(place: 2, race_id: 1, team_size: 1, participant_id: 3, field_size: 5),
          result(place: 3, race_id: 1, team_size: 1, participant_id: 4, field_size: 5),
    Severity: Major
    Found in test_ruby/models/competitions/calculations/teams_test.rb and 1 other location - About 1 hr to fix
    test_ruby/models/competitions/calculations/teams_test.rb on lines 106..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            expected = [
          result(place: 1, race_id: 1, team_size: 2, participant_id: 1, field_size: 1),
          result(place: 1, race_id: 1, team_size: 2, participant_id: 2, field_size: 1),
          result(place: 1, race_id: 2, team_size: 1, participant_id: 1, field_size: 1),
          result(place: 2, race_id: 3, team_size: 1, participant_id: 2, field_size: 4),
    Severity: Major
    Found in test_ruby/models/competitions/calculations/teams_test.rb and 1 other location - About 1 hr to fix
    test_ruby/models/competitions/calculations/teams_test.rb on lines 60..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            results = [
          result(place: 1, race_id: 1, participant_id: 1, field_size: 5),
          result(place: 2, race_id: 1, participant_id: 2, field_size: 5),
          result(place: 2, race_id: 1, participant_id: 3, field_size: 5),
          result(place: 3, race_id: 1, participant_id: 4, field_size: 5),
    Severity: Major
    Found in test_ruby/models/competitions/calculations/teams_test.rb and 1 other location - About 1 hr to fix
    test_ruby/models/competitions/calculations/teams_test.rb on lines 114..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            results = [
          result(place: 1, race_id: 1, participant_id: 1, field_size: 1),
          result(place: 1, race_id: 1, participant_id: 2, field_size: 1),
          result(place: 1, race_id: 2, participant_id: 1, field_size: 1),
          result(place: 2, race_id: 3, participant_id: 2, field_size: 4),
    Severity: Major
    Found in test_ruby/models/competitions/calculations/teams_test.rb and 1 other location - About 1 hr to fix
    test_ruby/models/competitions/calculations/teams_test.rb on lines 68..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            expected = [
          result(place: 1, race_id: 1, team_size: 2),
          result(place: 1, race_id: 1, team_size: 2),
          result(place: 2, race_id: 1, team_size: 1),
          result(place: 3, race_id: 1, team_size: 3),
    Severity: Major
    Found in test_ruby/models/competitions/calculations/teams_test.rb and 2 other locations - About 1 hr to fix
    test_ruby/models/competitions/calculations/teams_test.rb on lines 37..45
    test_ruby/models/competitions/calculations/teams_test.rb on lines 46..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            results = [
          result(place: 1, race_id: 1, team_size: 1),
          result(place: 1, race_id: 1, team_size: 1),
          result(place: 2, race_id: 1, team_size: 1),
          result(place: 3, race_id: 1, team_size: 1),
    Severity: Major
    Found in test_ruby/models/competitions/calculations/teams_test.rb and 2 other locations - About 1 hr to fix
    test_ruby/models/competitions/calculations/teams_test.rb on lines 15..23
    test_ruby/models/competitions/calculations/teams_test.rb on lines 37..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            expected = [
          result(place: 1, race_id: 1, team_size: 1),
          result(place: 1, race_id: 1, team_size: 1),
          result(place: 2, race_id: 1, team_size: 1),
          result(place: 3, race_id: 1, team_size: 1),
    Severity: Major
    Found in test_ruby/models/competitions/calculations/teams_test.rb and 2 other locations - About 1 hr to fix
    test_ruby/models/competitions/calculations/teams_test.rb on lines 15..23
    test_ruby/models/competitions/calculations/teams_test.rb on lines 46..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status