Sign upLogin

scrum2b/scrum2b

View on GitHub
Star
app/controllers/s2b_boards_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method sort has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def sort
    @max_position = Issue.where("status_id IS NULL or status_id IN (?) AND project_id IN (?)", STATUS_IDS[params[:new_status]],@hierarchy_project_id).maximum(:s2b_position)
    @issue = Issue.find(params[:issue_id])
    @old_position = @issue.s2b_position
    if params[:id_next].to_i != 0
Severity: Minor
Found in app/controllers/s2b_boards_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sort has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def sort
    @max_position = Issue.where("status_id IS NULL or status_id IN (?) AND project_id IN (?)", STATUS_IDS[params[:new_status]],@hierarchy_project_id).maximum(:s2b_position)
    @issue = Issue.find(params[:issue_id])
    @old_position = @issue.s2b_position
    if params[:id_next].to_i != 0
Severity: Minor
Found in app/controllers/s2b_boards_controller.rb - About 1 hr to fix

    Method filter_issues has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def filter_issues
    session[:params_select_version_onboard] = params[:select_version]
    session[:params_select_member] = params[:select_member]
    session[:conditions] = ["(1=1)"]
    if session[:params_select_version_onboard] && session[:params_select_version_onboard] != "all"
    Severity: Minor
    Found in app/controllers/s2b_boards_controller.rb - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                issue.update_attribute(:s2b_position, issue.s2b_position.to_i - 1) if issue.id != @issue.id
      Severity: Major
      Found in app/controllers/s2b_boards_controller.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

              elsif @next_position && @old_position > @next_position
        @sort_issue = Issue.where("status_id IN (?) AND s2b_position < ? AND s2b_position >= ?  AND project_id IN (?)", STATUS_IDS[params[:new_status]],@old_position,@next_position,@hierarchy_project_id)
        @sort_issue.each do |issue|
          issue.update_attribute(:s2b_position, issue.s2b_position.to_i + 1) if issue.id != @issue.id
        end
        Severity: Major
        Found in app/controllers/s2b_boards_controller.rb - About 45 mins to fix

          Method update_status has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def update_status
    @issue = Issue.find(params[:issue_id])
    unless @issue
      render :json => {:result => "error", :message => "Unknow issue"}
      return
          Severity: Minor
          Found in app/controllers/s2b_boards_controller.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  @sort_issue = Issue.where("status_id IN (?) AND s2b_position < ? AND s2b_position >= ?  AND project_id IN (?)", STATUS_IDS[params[:new_status]],@old_position,@next_position,@hierarchy_project_id)
        @sort_issue.each do |issue|
          issue.update_attribute(:s2b_position, issue.s2b_position.to_i + 1) if issue.id != @issue.id
        end
        @issue.update_attribute(:s2b_position, @next_position)
          Severity: Minor
          Found in app/controllers/s2b_boards_controller.rb and 1 other location - About 35 mins to fix
          app/controllers/s2b_boards_controller.rb on lines 86..90

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  @sort_issue = Issue.where("status_id IN (?) AND s2b_position > ? AND s2b_position <= ?  AND project_id IN (?)", STATUS_IDS[params[:new_status]],@old_position,@prev_position,@hierarchy_project_id)
        @sort_issue.each do |issue|
          issue.update_attribute(:s2b_position, issue.s2b_position.to_i - 1) if issue.id != @issue.id
        end
        @issue.update_attribute(:s2b_position, @prev_position)
          Severity: Minor
          Found in app/controllers/s2b_boards_controller.rb and 1 other location - About 35 mins to fix
          app/controllers/s2b_boards_controller.rb on lines 92..96

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status