sds/slim-lint

View on GitHub

Showing 7 of 9 total issues

Method extract_files_from has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def extract_files_from(patterns) # rubocop:disable Metrics/MethodLength
      files = []

      patterns.each do |pattern|
        if File.file?(pattern)
Severity: Minor
Found in lib/slim_lint/file_finder.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method for_consecutive_items has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def for_consecutive_items(items, satisfies, min_consecutive = 2)
      current_index = -1

      while (current_index += 1) < items.count
        next unless satisfies[items[current_index]]
Severity: Minor
Found in lib/slim_lint/utils.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def initialize(linter, filename, line, message, severity = :warning)
Severity: Minor
Found in lib/slim_lint/lint.rb - About 35 mins to fix

    Method match? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def match?(sexp_pattern)
          # Delegate matching logic if we're comparing against a matcher
          if sexp_pattern.is_a?(SlimLint::Matcher::Base)
            return sexp_pattern.match?(self)
          end
    Severity: Minor
    Found in lib/slim_lint/sexp.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method display has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def display(depth = 1) # rubocop:disable Metrics/AbcSize
          indentation = ' ' * 2 * depth
          output = '['.dup
    
          each_with_index do |nested_sexp, index|
    Severity: Minor
    Found in lib/slim_lint/sexp.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method act_on_options has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def act_on_options(options)
          log.color_enabled = options.fetch(:color, log.tty?)
    
          if options[:help]
            print_help(options)
    Severity: Minor
    Found in lib/slim_lint/cli.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method traverse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def traverse(sexp)
          patterns.each do |pattern|
            next unless sexp.match?(pattern.sexp)
    
            result = method(pattern.callback_method_name).call(sexp)
    Severity: Minor
    Found in lib/slim_lint/sexp_visitor.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language