Sign upLogin

se0ga/project-lvl2-s321

View on GitHub
Star

Showing 6 of 6 total issues

Function createAST has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const createAST = (obj1, obj2) => {
  const keys = _.union(Object.keys(obj1), Object.keys(obj2));
  return keys.map((key) => {
    if (_.isObject(obj1[key]) && _.isObject(obj2[key])) {
      return {
Severity: Minor
Found in src/ast.js - About 1 hr to fix

    Function render has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const render = (ast) => {
  const iter = (list, depth) => {
    const newList = list.map((elem) => {
      const { key } = elem;
      const oldValue = stringify(elem.oldValue, depth);
    Severity: Minor
    Found in src/renderers/diff.js - About 1 hr to fix

      Function iter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const iter = (list, depth) => {
    const newList = list.map((elem) => {
      const { key } = elem;
      const oldValue = stringify(elem.oldValue, depth);
      const newValue = stringify(elem.newValue, depth);
      Severity: Minor
      Found in src/renderers/diff.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        test('check gendiff with json, yml, ini with --format plain', () => {
  files.forEach(([file1, file2, resultFile]) => checkGendiffResult(file1, file2, `plain${resultFile}`, 'plain'));
});
        Severity: Minor
        Found in __tests__/gendiff.test.js and 1 other location - About 40 mins to fix
        __tests__/gendiff.test.js on lines 25..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        test('check gendiff with json, yml, ini with --format json', () => {
  files.forEach(([file1, file2, resultFile]) => checkGendiffResult(file1, file2, `json${resultFile}`, 'json'));
});
        Severity: Minor
        Found in __tests__/gendiff.test.js and 1 other location - About 40 mins to fix
        __tests__/gendiff.test.js on lines 22..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

            return {
      key,
      oldValue: obj1[key],
      newValue: obj2[key],
      type: 'changed',
        Severity: Major
        Found in src/ast.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language