Sign upLogin

sealink/rails_core_extensions

View on GitHub
Star

Showing 3 of 3 total issues

Method validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def validate(record)
        required_fields = Array.wrap(@options[:attributes]).first.call || []
        return if required_fields.empty?

        required_fields.flatten.each do |required_field|
Severity: Minor
Found in lib/rails_core_extensions/active_model_extensions.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sort has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def sort
      scope = @params[:scope].try(:to_sym)
      @params[scope] = nil if @params[scope].blank?

      body_key = @controller_name.singularize + (@params[scope] ? "_#{@params[scope]}" : '')
Severity: Minor
Found in lib/rails_core_extensions/sortable.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method activate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def activate(success_block = nil)
      resource.active = params[:active].presence || false
      action = resource.active ? 'activate' : 'inactivate'

      resource.save!
Severity: Minor
Found in lib/rails_core_extensions/activatable.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language