Sign upLogin

sealink/timely

View on GitHub
Star
lib/timely/date_chooser.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method choose_dates has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def choose_dates
      # Not multiple dates - just return the From date.
      return [@from] unless @multiple_dates

      # Multiple dates - return the array, adjusted as per input
Severity: Minor
Found in lib/timely/date_chooser.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method choose_dates has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def choose_dates
      # Not multiple dates - just return the From date.
      return [@from] unless @multiple_dates

      # Multiple dates - return the array, adjusted as per input
Severity: Minor
Found in lib/timely/date_chooser.rb - About 1 hr to fix

    Method validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate
      raise DateChooserException, 'A Start Date is required' unless @from
      raise DateChooserException, 'Start Date is after End Date' if @multiple_dates && @to && @from > @to

      @to ||= @from if @multiple_dates
    Severity: Minor
    Found in lib/timely/date_chooser.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status