Sign upLogin

sealink/timely

View on GitHub
Star
lib/timely/temporal_patterns/pattern.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method to_s has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def to_s
        single_date_intervals, multiple_dates_intervals = intervals.partition { |i| i.first_datetime == i.last_datetime}
        patterns_strings = if multiple_dates_intervals.empty?
          single_date_intervals.map(&:to_s)
        else
Severity: Minor
Found in lib/timely/temporal_patterns/pattern.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_s has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def to_s
        single_date_intervals, multiple_dates_intervals = intervals.partition { |i| i.first_datetime == i.last_datetime}
        patterns_strings = if multiple_dates_intervals.empty?
          single_date_intervals.map(&:to_s)
        else
Severity: Minor
Found in lib/timely/temporal_patterns/pattern.rb - About 1 hr to fix

    Method join has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def join(other)
        return nil unless self.frequency == other.frequency

        expanded_datetimes = self.datetimes.map { |datetimes_within_an_interval|
          back_one    = datetimes_within_an_interval.first - frequency.duration
    Severity: Minor
    Found in lib/timely/temporal_patterns/pattern.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fix_frequency has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def fix_frequency
        return unless frequency.duration > 1.month
        if frequency.duration < 12.months
          if intervals.all? { |i| i.first_datetime.day == i.last_datetime.day }
            frequency.duration = frequency.units[:months].months
    Severity: Minor
    Found in lib/timely/temporal_patterns/pattern.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status