Sign upLogin

seamusabshere/lock_and_cache

View on GitHub
Star

Showing 3 of 3 total issues

Method perform has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    def perform
      max_lock_wait = options.fetch 'max_lock_wait', LockAndCache.max_lock_wait
      heartbeat_expires = options.fetch('heartbeat_expires', LockAndCache.heartbeat_expires).to_f.ceil
      raise "heartbeat_expires must be >= 2 seconds" unless heartbeat_expires >= 2
      heartbeat_frequency = (heartbeat_expires / 2).ceil
Severity: Minor
Found in lib/lock_and_cache/action.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def perform
      max_lock_wait = options.fetch 'max_lock_wait', LockAndCache.max_lock_wait
      heartbeat_expires = options.fetch('heartbeat_expires', LockAndCache.heartbeat_expires).to_f.ceil
      raise "heartbeat_expires must be >= 2 seconds" unless heartbeat_expires >= 2
      heartbeat_frequency = (heartbeat_expires / 2).ceil
Severity: Major
Found in lib/lock_and_cache/action.rb - About 2 hrs to fix

    Method extract_obj_id has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def extract_obj_id(obj)
        klass = obj.class
        if ALLOWED_IN_KEYS.include?(klass)
          obj
        elsif DATE.include?(klass)
    Severity: Minor
    Found in lib/lock_and_cache/key.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language