Sign upLogin

seanedwards/cfer

View on GitHub
Star

Showing 26 of 26 total issues

Method tail has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def tail(options = {})
      q = []
      event_id_highwater = nil
      counter = 0
      number = options[:number] || 0
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method converge! has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def converge!(stack_name, options = {})
      config(options)
      options[:on_failure].upcase! if options[:on_failure]
      tmpl = options[:template] || "#{stack_name}.rb"
      cfn = options[:aws_options] || {}
Severity: Minor
Found in lib/cfer.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method converge has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def converge(stack, options = {})
      Preconditions.check(@name).is_not_nil
      Preconditions.check(stack) { is_not_nil and has_type(Cfer::Core::Stack) }

      template_options = upload_or_return_template(stack.to_cfn, options)
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File cfer.rb has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'active_support/all'
require 'aws-sdk-cloudformation'
require 'aws-sdk-s3'
require 'logger'
require 'json'
Severity: Minor
Found in lib/cfer.rb - About 2 hrs to fix

Class Client has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client < Cfer::Core::Client
    attr_reader :name
    attr_reader :stack

    def initialize(options)
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 2 hrs to fix

Method converge has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def converge(stack, options = {})
      Preconditions.check(@name).is_not_nil
      Preconditions.check(stack) { is_not_nil and has_type(Cfer::Core::Stack) }

      template_options = upload_or_return_template(stack.to_cfn, options)
Severity: Major
Found in lib/cfer/cfn/client.rb - About 2 hrs to fix

File client.rb has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative '../core/client'
require 'uri'

module Cfer::Cfn
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 2 hrs to fix

Method describe! has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def describe!(stack_name, options = {})
      config(options)
      cfn = options[:aws_options] || {}
      cfn_stack = options[:cfer_client] || Cfer::Cfn::Client.new(cfn.merge(stack_name: stack_name))
      cfn_metadata = cfn_stack.fetch_metadata
Severity: Minor
Found in lib/cfer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load_from_path has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def load_from_path
        profile = load_profile
        credentials = Aws::Credentials.new(
          profile['aws_access_key_id'],
          profile['aws_secret_access_key'],
Severity: Minor
Found in lib/cfer/cfn/cfer_credentials_provider.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tail has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def tail(options = {})
      q = []
      event_id_highwater = nil
      counter = 0
      number = options[:number] || 0
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 1 hr to fix

Method converge! has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def converge!(stack_name, options = {})
      config(options)
      options[:on_failure].upcase! if options[:on_failure]
      tmpl = options[:template] || "#{stack_name}.rb"
      cfn = options[:aws_options] || {}
Severity: Minor
Found in lib/cfer.rb - About 1 hr to fix

Method load_from_path has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def load_from_path
        profile = load_profile
        credentials = Aws::Credentials.new(
          profile['aws_access_key_id'],
          profile['aws_secret_access_key'],
Severity: Minor
Found in lib/cfer/cfn/cfer_credentials_provider.rb - About 1 hr to fix

Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(options = {})
      self[:AWSTemplateFormatVersion] = '2010-09-09'
      self[:Description] = ''

      @options = options
Severity: Minor
Found in lib/cfer/core/stack.rb - About 1 hr to fix

Method describe! has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def describe!(stack_name, options = {})
      config(options)
      cfn = options[:aws_options] || {}
      cfn_stack = options[:cfer_client] || Cfer::Cfn::Client.new(cfn.merge(stack_name: stack_name))
      cfn_metadata = cfn_stack.fetch_metadata
Severity: Minor
Found in lib/cfer.rb - About 1 hr to fix

Method parameter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def parameter(name, **options)
      param = {}
      options.each do |key, v|
        next if v === nil
Severity: Minor
Found in lib/cfer/core/stack.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method main has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.main(args)
      Cfer::LOGGER.debug "Cfer version #{Cfer::VERSION}"
      begin
        CFER_CLI.run(args)
      rescue Aws::Errors::NoSuchProfileError => e
Severity: Minor
Found in lib/cfer/cli.rb - About 1 hr to fix

Method main has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def self.main(args)
      Cfer::LOGGER.debug "Cfer version #{Cfer::VERSION}"
      begin
        CFER_CLI.run(args)
      rescue Aws::Errors::NoSuchProfileError => e
Severity: Minor
Found in lib/cfer/cli.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method delete! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def delete!(stack_name, options = {})
      config(options)
      cfn = options[:aws_options] || {}
      cfn_stack = options[:cfer_client] || cfn_stack = Cfer::Cfn::Client.new(cfn.merge(stack_name: stack_name))
Severity: Minor
Found in lib/cfer.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(options = {})
      self[:AWSTemplateFormatVersion] = '2010-09-09'
      self[:Description] = ''

      @options = options
Severity: Minor
Found in lib/cfer/core/stack.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                rollback_opts[:role_arn] = options[:role_arn] if options[:role_arn]
Severity: Major
Found in lib/cfer.rb - About 45 mins to fix
Severity
Category
Status
Source
Language