Sign upLogin

seatplus/eveapi

View on GitHub
Star

Showing 31 of 159 total issues

Missing class import via use statement (line '63', column '60').
Confirmed

        throw_unless(count($this->manual_ids) <= 1000, new \Exception('Character ids must not exceed 1000'));
Severity: Minor
Found in src/Jobs/Character/CharacterAffiliationJob.php by phpmd

Missing class import via use statement (line '144', column '34').
Confirmed

            default => throw new \Exception("Unknown recipient type {$recipient_type}"),
Severity: Minor
Found in src/Jobs/Mail/MailHeaderJob.php by phpmd

Missing class import via use statement (line '61', column '38').
Confirmed

                default => throw new \Exception("Unexpected key: {$key}")
Severity: Minor
Found in src/Traits/HasRequiredScopes.php by phpmd

The method handle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Confirmed

        } else {
            RefreshToken::with(['corporation', 'character.roles'])
                ->cursor()
                ->map(fn (RefreshToken $token) => $token->corporation?->corporation_id)
                ->filter()
Severity: Minor
Found in src/Jobs/Seatplus/UpdateCorporation.php by phpmd

The method incrementEsiRateLimit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            cache()->set($this->ratelimit_key, $amount, carbon('now')
                ->addMinutes($this->ratelimit_duration));
        }
Severity: Minor
Found in src/Traits/RateLimitsEsiCalls.php by phpmd

TODO found
Confirmed

            // TODO check which columns are actually can be updated
Severity: Minor
Found in src/Jobs/Contracts/CharacterContractsJob.php by fixme

TODO found
Confirmed

        return $query // TODO merge tables like assets for improved db performance
Severity: Minor
Found in src/Models/Contracts/Contract.php by fixme

TODO found
Open

            // TODO: Missing Affiliations from character_users, character_info and contacts
Severity: Minor
Found in src/Jobs/Seatplus/MaintenanceJob.php by fixme

TODO found
Confirmed

            // TODO: Update CorporationInfo and AllianceInfo
Severity: Minor
Found in src/Jobs/Seatplus/MaintenanceJob.php by fixme

TODO found
Confirmed

            // TODO: Missing character_info from character_users
Severity: Minor
Found in src/Jobs/Seatplus/MaintenanceJob.php by fixme

TODO found
Confirmed

        return parent::delete(); // TODO: Change the autogenerated stub
Severity: Minor
Found in src/Models/Killmails/KillmailItem.php by fixme
Severity
Category
Status
Source
Language