src/Jobs/Contracts/CharacterContractsJob.php
Method executeJob
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Wontfix
Wontfix
public function executeJob(): void
{
$contracts = collect();
while (true) {
Method persist
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Confirmed
Confirmed
private function persist(Collection $contracts)
{
Contract::upsert(
$contracts->toArray(),
['contract_id'],
Function executeJob
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Wontfix
Wontfix
public function executeJob(): void
{
$contracts = collect();
while (true) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
TODO found Confirmed
Confirmed
// TODO check which columns are actually can be updated
- Exclude checks