Sign upLogin

seb86/Auto-Load-Next-Post

View on GitHub
Star
includes/admin/settings/class-alnp-settings-theme-selectors.php

Summary

Maintainability
C
1 day
Test Coverage

Method get_settings has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function get_settings() {
            global $blog_id;

            $settings = array();
Severity: Major
Found in includes/admin/settings/class-alnp-settings-theme-selectors.php - About 4 hrs to fix

    Function get_settings has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

            public function get_settings() {
            global $blog_id;

            $settings = array();
    Severity: Minor
    Found in includes/admin/settings/class-alnp-settings-theme-selectors.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function no_theme_selectors_set has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            public static function no_theme_selectors_set() {
            $set_selectors = array();

            $content_container    = get_option( 'auto_load_next_post_content_container' );
            $title_selector       = get_option( 'auto_load_next_post_title_selector' );
    Severity: Minor
    Found in includes/admin/settings/class-alnp-settings-theme-selectors.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function is_theme_supported has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            public static function is_theme_supported() {
            if ( is_alnp_supported() ) {
                $plugin_supported = alnp_get_theme_support( 'plugin_support' );

                // Is the theme supported by theme or plugin?
    Severity: Minor
    Found in includes/admin/settings/class-alnp-settings-theme-selectors.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                $settings[] = array(
                'title'       => esc_html__( 'Post Title', 'auto-load-next-post' ),
                'desc'        => sprintf( __( 'Used to identify which article the user is reading and track should Google Analytics or other analytics be enabled. %s', 'auto-load-next-post' ), $post_title_default ),
                'id'          => 'auto_load_next_post_title_selector',
                'default'     => 'h1.entry-title',
    Severity: Major
    Found in includes/admin/settings/class-alnp-settings-theme-selectors.php and 2 other locations - About 1 hr to fix
    includes/admin/settings/class-alnp-settings-theme-selectors.php on lines 150..161
    includes/admin/settings/class-alnp-settings-theme-selectors.php on lines 190..201

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                $settings[] = array(
                'title'       => esc_html__( 'Content Container', 'auto-load-next-post' ),
                'desc'        => sprintf( __( 'The primary container where the post content is loaded in. %s', 'auto-load-next-post' ), $container_default ),
                'id'          => 'auto_load_next_post_content_container',
                'default'     => 'main.site-main',
    Severity: Major
    Found in includes/admin/settings/class-alnp-settings-theme-selectors.php and 2 other locations - About 1 hr to fix
    includes/admin/settings/class-alnp-settings-theme-selectors.php on lines 170..181
    includes/admin/settings/class-alnp-settings-theme-selectors.php on lines 190..201

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                $settings[] = array(
                'title'       => esc_html__( 'Post Navigation', 'auto-load-next-post' ),
                'desc'        => sprintf( __( 'Used to identify which post to load next if any. %s', 'auto-load-next-post' ), $post_navigation_default ),
                'id'          => 'auto_load_next_post_navigation_container',
                'default'     => 'nav.post-navigation',
    Severity: Major
    Found in includes/admin/settings/class-alnp-settings-theme-selectors.php and 2 other locations - About 1 hr to fix
    includes/admin/settings/class-alnp-settings-theme-selectors.php on lines 150..161
    includes/admin/settings/class-alnp-settings-theme-selectors.php on lines 170..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status