sebastian-software/core

View on GitHub
source/class/core/property/MGeneric.js

Summary

Maintainability
D
2 days
Test Coverage

Function isValid has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            isValid : function(property, raise)
            {
                if (typeof property == "string")
                {
                    var method = validators[property];
Severity: Minor
Found in source/class/core/property/MGeneric.js - About 1 hr to fix

    Function get has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                get : function(property)
                {
                    if (typeof property == "string")
                    {
                        var method = getters[property];
    Severity: Minor
    Found in source/class/core/property/MGeneric.js - About 1 hr to fix

      Function reset has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  reset : function(property)
                  {
                      if (typeof property == "string")
                      {
                          var method = resetters[property];
      Severity: Minor
      Found in source/class/core/property/MGeneric.js - About 1 hr to fix

        Function set has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    set : function(property, value)
                    {
                        if (arguments.length == 2)
                        {
                            if (jasy.Env.isSet("debug")) {
        Severity: Minor
        Found in source/class/core/property/MGeneric.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                      if (raise) {
                                          throw new Error("Property " + name + " in " + this + " is not valid!");
                                      } else {
                                          return false;
                                      }
          Severity: Major
          Found in source/class/core/property/MGeneric.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (typeof property == "string")
                            {
                                var method = getters[property];
                                if (!method) {
                                    method = getters[property] = "get" + up(property);
            Severity: Major
            Found in source/class/core/property/MGeneric.js and 1 other location - About 3 hrs to fix
            source/class/core/property/MGeneric.js on lines 166..204

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (typeof property == "string")
                            {
                                var method = resetters[property];
                                if (!method) {
                                    method = resetters[property] = "reset" + up(property);
            Severity: Major
            Found in source/class/core/property/MGeneric.js and 1 other location - About 3 hrs to fix
            source/class/core/property/MGeneric.js on lines 110..152

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                if (!property)
                                {
                                    property = core.Object.getKeys(core.Class.getProperties(this.constructor));
                                }
                                else if (jasy.Env.isSet("debug"))
            Severity: Major
            Found in source/class/core/property/MGeneric.js and 1 other location - About 2 hrs to fix
            source/class/core/property/MGeneric.js on lines 125..132

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 80.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                if (!property)
                                {
                                    property = core.Object.getKeys(core.Class.getProperties(this.constructor));
                                }
                                else if (jasy.Env.isSet("debug"))
            Severity: Major
            Found in source/class/core/property/MGeneric.js and 1 other location - About 2 hrs to fix
            source/class/core/property/MGeneric.js on lines 181..188

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 80.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status