sebastian-software/core

File Multi.js has 524 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
==================================================================================================
  Core - JavaScript Foundation
  Copyright 2010-2012 Zynga Inc.
  Copyright 2012-2014 Sebastian Werner

Function create has 200 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        create : function(config)
        {
            /*
            ---------------------------------------------------------------------------
                 INTRO: IDENTICAL BETWEEN SIMPLE AND MULTI

Function importData has 98 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        importData : function(obj, values, oldValues, field)
        {
            // Check existence of data structure
            var data = obj[store];
            if (!data) {

Function moveObject has 80 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        moveObject : function(obj, newParent, oldParent)
        {
            // Fast compare (e.g. both null - should not happen, but still)
            if (newParent == oldParent) {
                return;

Function changeInheritedHelper has 69 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    var changeInheritedHelper = function(obj, newValue, oldValue, config)
    {
        // TODO: Improved this lookup via $$children
        if (!obj._getChildren) {
            return;

Function resetter has 56 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            var resetter = function(modifyPriority)
            {
                return function(value)
                {
                    var context = this;

Function setter has 50 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            var setter = function(modifyPriority)
            {
                return function(newValue)
                {
                    var context = this;

Function getter has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            var getter = function()
            {
                var context = this;

                if (jasy.Env.isSet("debug")) {

Avoid deeply nested control flow statements.

Open

                            if (!config.nullable) {
                                obj.error("Missing value for: " + propertyName + " (during reset() - from theme system)");
                            }

Avoid too many return statements within this function.

Open

                        return context[currentGetter](name);

Avoid too many return statements within this function.

Open

                    return data[propertyId+currentPriority];

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                        if (newValue !== oldValue)
                        {
                            // Call apply
                            if (propertyApply) {
                                context[propertyApply](newValue, oldValue, config.name);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                    if (oldPriority === modifyPriority && oldValue !== newValue)
                    {
                        // Call apply
                        if (propertyApply) {
                            context[propertyApply](newValue, oldValue, config.name);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    for (var newPriority=modifyPriority-1; newPriority>0; newPriority--)
                    {
                        newGetter = priorityToFieldConfig[newPriority].get;
                        if (newGetter) {
                            newValue = obj[newGetter] ? obj[newGetter](propertyName) : Undefined;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        for (var newPriority=modifyPriority-1; newPriority>0; newPriority--)
                        {
                            newGetter = priorityToFieldConfig[newPriority].get;
                            if (newGetter) {
                                newValue = context[newGetter] ? context[newGetter](name) : Undefined;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                            if (propertyInit !== Undefined) {
                                newValue = propertyInit;
                            }
                            else if (jasy.Env.isSet("debug"))
                            {

• Read up
  Read up