source/core/datastore/types/googlecalendar/MGoogleCalendarDatastore.php
Avoid unused parameters such as '$template'. Open
Open
public function searchByTemplate(MWebfile $template)- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$count'. Open
Open
public function getLatestWebfiles($count = 5)- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
TODO found Open
Open
// TODO: Implement searchByTemplate() method.- Create a ticketCreate a ticket
- Exclude checks
TODO found Open
Open
// TODO: Implement getLatestWebfiles() method.- Create a ticketCreate a ticket
- Exclude checks
The method getClientWithToken uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
throw new MDatastoreException("No credentials set. Please request new Credentials.");
}- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid excessively long variable names like $authConfigAsJsonString. Keep variable name length under 20. Open
Open
private $authConfigAsJsonString;- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $authConfigAsJsonString. Keep variable name length under 20. Open
Open
public function __construct($calendarId, $authConfigAsJsonString, $redirectUrl, MISecretStore $secretStore)- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}Source https://phpmd.org/rules/naming.html#longvariable
The property $m_sCalendarId is not named in camelCase. Open
Open
class MGoogleCalendarDatastore extends MAbstractCachableDatastore
implements MISingleDatasourceDatastore
{
// https://developers.google.com/google-apps/calendar/quickstart/php#step_2_install_the_google_client_library
/** @var string */- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}