Sign upLogin

sebastianmonzel/webfiles-framework-php

View on GitHub
Star
source/core/datastore/types/remote/MRemoteDatastore.php

Summary

Maintainability
A
1 hr
Test Coverage
D
63%

The method tryConnect uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return false;
        }
Severity: Minor
Found in source/core/datastore/types/remote/MRemoteDatastore.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method isReadOnly uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return false;
        }
Severity: Minor
Found in source/core/datastore/types/remote/MRemoteDatastore.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

TODO found
Open

    // TODO exceptions von originärem datastore wie druchreichen?
Severity: Minor
Found in source/core/datastore/types/remote/MRemoteDatastore.php by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function deleteByTemplate(MWebfile $template)
    {

        $marshallAsJson = $this->m_sFormat == "json";
Severity: Minor
Found in source/core/datastore/types/remote/MRemoteDatastore.php and 1 other location - About 55 mins to fix
source/core/datastore/types/remote/MRemoteDatastore.php on lines 128..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function storeWebfile(MWebfile $webfile)
    {

        $marshallAsJson = $this->m_sFormat == "json";
Severity: Minor
Found in source/core/datastore/types/remote/MRemoteDatastore.php and 1 other location - About 55 mins to fix
source/core/datastore/types/remote/MRemoteDatastore.php on lines 149..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $callResultAsWebfileStreamXml. Keep variable name length under 20.
Open

        $callResultAsWebfileStreamXml = $this->doRemoteCall($data);
Severity: Minor
Found in source/core/datastore/types/remote/MRemoteDatastore.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $callResultAsWebfileStreamXml. Keep variable name length under 20.
Open

        $callResultAsWebfileStreamXml = $this->doRemoteCall($data);
Severity: Minor
Found in source/core/datastore/types/remote/MRemoteDatastore.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The property $m_sDatastoreUrl is not named in camelCase.
Open

class MRemoteDatastore extends MAbstractDatastore
{
    // TODO exceptions von originärem datastore wie druchreichen?
    private $m_sDatastoreUrl;
    private $m_sFormat;
Severity: Minor
Found in source/core/datastore/types/remote/MRemoteDatastore.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $m_sFormat is not named in camelCase.
Open

class MRemoteDatastore extends MAbstractDatastore
{
    // TODO exceptions von originärem datastore wie druchreichen?
    private $m_sDatastoreUrl;
    private $m_sFormat;
Severity: Minor
Found in source/core/datastore/types/remote/MRemoteDatastore.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

There are no issues that match your filters.

Category
Status