sebastianmonzel/webfiles-framework-php

View on GitHub
source/io/form/MForm.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Method addFormHeadersToSite has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function addFormHeadersToSite($site)
    {


        $site->addHeader("<link rel=\"stylesheet\" href=\"http://ajax.googleapis.com/ajax/libs/dojo/1.8.10/dijit/themes/claro/claro.css\">");
Severity: Minor
Found in source/io/form/MForm.php - About 1 hr to fix

Function addFormItem has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    function addFormItem(MAbstractFormItem $formItem, $precedingFormItemName = null)
    {

        if ($precedingFormItemName == null) {
            array_push($this->formItems, $formItem);
Severity: Minor
Found in source/io/form/MForm.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method addFormItem uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {

            $formItems = array();

            foreach ($this->formItems as $iteratingFormItem) {
Severity: Minor
Found in source/io/form/MForm.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid excessively long variable names like $precedingFormItemName. Keep variable name length under 20.
Open

    function addFormItem(MAbstractFormItem $formItem, $precedingFormItemName = null)
Severity: Minor
Found in source/io/form/MForm.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category
Status