Sign upLogin

secrethub/ansible-secrethub

View on GitHub
Star
library/secrethub_cli.py

Summary

Maintainability
A
25 mins
Test Coverage

Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.
Open

            return urlopen('https://get.secrethub.io/releases/LATEST').read().decode()
Severity: Minor
Found in library/secrethub_cli.py by bandit

subprocess call - check for execution of untrusted input.
Open

            p = subprocess.Popen(
                [self.bin_path(), '--version'],
                stdout=subprocess.PIPE,
                stderr=subprocess.PIPE,
Severity: Info
Found in library/secrethub_cli.py by bandit

Consider possible security implications associated with subprocess module.
Open

import subprocess
Severity: Info
Found in library/secrethub_cli.py by bandit

Chmod setting a permissive mask 0o711 on file (NOT PARSED).
Open

        os.chmod(self.bin_path(), 0o711)
Severity: Minor
Found in library/secrethub_cli.py by bandit

Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.
Open

            urlretrieve(fetch_url, tmp_file)
Severity: Minor
Found in library/secrethub_cli.py by bandit

Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def run(self):
        """ Installs or upgrades the SecretHub CLI when needed.

        Installs the SecretHub CLI when the CLI is not yet installed in the configured path.
        When a different version of the CLI is installed, it is upgraded/downgraded.
Severity: Minor
Found in library/secrethub_cli.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Merge this if statement with the enclosing one.
Open

            if current_version is not None:
Severity: Major
Found in library/secrethub_cli.py by sonar-python

Merging collapsible if statements increases the code's readability.

Noncompliant Code Example

if condition1:
    if condition2:
        # ...

Compliant Solution

if condition1 and condition2:
    # ...

There are no issues that match your filters.

Category
Status