Sign upLogin

secureCodeBox/secureCodeBox

View on GitHub
Star
auto-discovery/cloud-aws/pkg/aws/aws.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method MonitorService.Run has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
Open

func (m *MonitorService) Run(ctx context.Context) {
    m.Log.Info("Receiving messages...")
    for {
        select {
        case <-ctx.Done():
Severity: Minor
Found in auto-discovery/cloud-aws/pkg/aws/aws.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if err != nil {
                        m.Log.Error(err, "Error handling AWS event")
                        continue
                    }
Severity: Major
Found in auto-discovery/cloud-aws/pkg/aws/aws.go - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if len(requests) > 0 {
                        for _, request := range requests {
                            err = m.Reconciler.Reconcile(ctx, request)
                            if err != nil {
                                m.Log.Error(err, "Unable to reconcile request")
    Severity: Major
    Found in auto-discovery/cloud-aws/pkg/aws/aws.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if !errors {
                        // delete message from the service
                        // if there was a kubernetes error the message will be kept and tried again
                        // this might forever retry the same message or messages
                        m.deleteMessageFromQueue(ctx, message.ReceiptHandle)
      Severity: Major
      Found in auto-discovery/cloud-aws/pkg/aws/aws.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status