Sign upLogin

secureCodeBox/secureCodeBox

View on GitHub
Star
auto-discovery/kubernetes/pkg/util/filter.go

Summary

Maintainability
D
2 days
Test Coverage

Function getPredicatesForEnabledPerNamespace has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
Open

func getPredicatesForEnabledPerNamespace(client client.Client, log logr.Logger) predicate.Predicate {
    return predicate.Funcs{
        CreateFunc: func(event event.CreateEvent) bool {

            if val, ok := event.Object.GetAnnotations()["auto-discovery.securecodebox.io/ignore"]; ok && val == "true" {
Severity: Minor
Found in auto-discovery/kubernetes/pkg/util/filter.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getPredicatesForEnabledPerNamespace has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func getPredicatesForEnabledPerNamespace(client client.Client, log logr.Logger) predicate.Predicate {
    return predicate.Funcs{
        CreateFunc: func(event event.CreateEvent) bool {

            if val, ok := event.Object.GetAnnotations()["auto-discovery.securecodebox.io/ignore"]; ok && val == "true" {
Severity: Minor
Found in auto-discovery/kubernetes/pkg/util/filter.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func getPredicatesForEnabledPerResource(client client.Client, log logr.Logger) predicate.Predicate {
    return predicate.Funcs{
        CreateFunc: func(event event.CreateEvent) bool {
            if val, ok := event.Object.GetAnnotations()["auto-discovery.securecodebox.io/enabled"]; ok && val == "true" {
                return true
    Severity: Major
    Found in auto-discovery/kubernetes/pkg/util/filter.go and 1 other location - About 4 hrs to fix
    auto-discovery/kubernetes/pkg/util/filter.go on lines 150..177

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 325.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func getPredicatesForScanAll(client client.Client, log logr.Logger) predicate.Predicate {
    return predicate.Funcs{
        CreateFunc: func(event event.CreateEvent) bool {
            if val, ok := event.Object.GetAnnotations()["auto-discovery.securecodebox.io/ignore"]; ok && val == "true" {
                return false
    Severity: Major
    Found in auto-discovery/kubernetes/pkg/util/filter.go and 1 other location - About 4 hrs to fix
    auto-discovery/kubernetes/pkg/util/filter.go on lines 121..148

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 325.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            DeleteFunc: func(event event.DeleteEvent) bool {
            if val, ok := event.Object.GetAnnotations()["auto-discovery.securecodebox.io/ignore"]; ok && val == "true" {
                return false
            }
    Severity: Major
    Found in auto-discovery/kubernetes/pkg/util/filter.go and 3 other locations - About 1 hr to fix
    auto-discovery/kubernetes/pkg/util/filter.go on lines 57..72
    auto-discovery/kubernetes/pkg/util/filter.go on lines 88..102
    auto-discovery/kubernetes/pkg/util/filter.go on lines 103..117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 144.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            GenericFunc: func(event event.GenericEvent) bool {
            if val, ok := event.Object.GetAnnotations()["auto-discovery.securecodebox.io/ignore"]; ok && val == "true" {
                return false
            }
    Severity: Major
    Found in auto-discovery/kubernetes/pkg/util/filter.go and 3 other locations - About 1 hr to fix
    auto-discovery/kubernetes/pkg/util/filter.go on lines 57..72
    auto-discovery/kubernetes/pkg/util/filter.go on lines 73..87
    auto-discovery/kubernetes/pkg/util/filter.go on lines 88..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 144.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            CreateFunc: func(event event.CreateEvent) bool {

            if val, ok := event.Object.GetAnnotations()["auto-discovery.securecodebox.io/ignore"]; ok && val == "true" {
                return false
            }
    Severity: Major
    Found in auto-discovery/kubernetes/pkg/util/filter.go and 3 other locations - About 1 hr to fix
    auto-discovery/kubernetes/pkg/util/filter.go on lines 73..87
    auto-discovery/kubernetes/pkg/util/filter.go on lines 88..102
    auto-discovery/kubernetes/pkg/util/filter.go on lines 103..117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 144.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            UpdateFunc: func(event event.UpdateEvent) bool {
            if val, ok := event.ObjectNew.GetAnnotations()["auto-discovery.securecodebox.io/ignore"]; ok && val == "true" {
                return false
            }
    Severity: Major
    Found in auto-discovery/kubernetes/pkg/util/filter.go and 3 other locations - About 1 hr to fix
    auto-discovery/kubernetes/pkg/util/filter.go on lines 57..72
    auto-discovery/kubernetes/pkg/util/filter.go on lines 73..87
    auto-discovery/kubernetes/pkg/util/filter.go on lines 103..117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 144.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status