Sign upLogin

secynic/ipwhois

View on GitHub
Star
ipwhois/hr.py

Summary

Maintainability
C
1 day
Test Coverage

File hr.py has 478 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright (c) 2013-2020 Philip Hane
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are met:
Severity: Minor
Found in ipwhois/hr.py - About 7 hrs to fix

TODO found
Open

# TODO: Add '_links' for RFC/other references
Severity: Minor
Found in ipwhois/hr.py by fixme

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    'notices': {
        '_short': 'Notices',
        '_name': 'Notices',
        '_description': 'Notices for an RIR object.',
        'description': {
Severity: Major
Found in ipwhois/hr.py and 2 other locations - About 1 hr to fix
ipwhois/hr.py on lines 101..119
ipwhois/hr.py on lines 152..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    'remarks': {
        '_short': 'Remarks',
        '_name': 'Remarks',
        '_description': 'Remarks for an RIR object.',
        'description': {
Severity: Major
Found in ipwhois/hr.py and 2 other locations - About 1 hr to fix
ipwhois/hr.py on lines 101..119
ipwhois/hr.py on lines 132..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    'events': {
        '_short': 'Events',
        '_name': 'Events',
        '_description': 'Events for an RIR object.',
        'action': {
Severity: Major
Found in ipwhois/hr.py and 2 other locations - About 1 hr to fix
ipwhois/hr.py on lines 132..149
ipwhois/hr.py on lines 152..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status