Sign upLogin

secynic/ipwhois

View on GitHub
Star

Showing 266 of 266 total issues

Avoid too many return statements within this function.
Open

        return results(True, 'TEST-NET-3', 'RFC 5737')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return results(True, 'Multicast', 'RFC 3171')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return results(True, 'Private-Use Networks', 'RFC 1918')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return results(False, '', '')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        try:

            asn_data = {
                'asn_registry': None,
                'asn': None,
Severity: Major
Found in ipwhois/asn.py and 3 other locations - About 30 mins to fix
ipwhois/asn.py on lines 141..168
ipwhois/asn.py on lines 198..225
ipwhois/asn.py on lines 255..282

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        try:

            temp = response.split('|')

            # Parse out the ASN information.
Severity: Major
Found in ipwhois/asn.py and 3 other locations - About 30 mins to fix
ipwhois/asn.py on lines 141..168
ipwhois/asn.py on lines 255..282
ipwhois/asn.py on lines 331..382

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return results(True, 'IANA Reserved', '')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return (results(True,
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return results(True, 'Link-Local', 'RFC 4291, Section 2.5.6')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        try:

            temp = response.split('|')

            # Parse out the ASN information.
Severity: Major
Found in ipwhois/asn.py and 3 other locations - About 30 mins to fix
ipwhois/asn.py on lines 198..225
ipwhois/asn.py on lines 255..282
ipwhois/asn.py on lines 331..382

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return results(True, 'TEST-NET-2', 'RFC 5737')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return results(True, 'Site-Local', 'RFC 4291, Section 2.5.7')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return results(True, 'Limited Broadcast', 'RFC 919, Section 7')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return results(True, 'Unique Local Unicast', 'RFC 4193')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return results(False, '', '')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return results(True, 'TEST-NET-1', 'RFC 5737')
Severity: Major
Found in ipwhois/utils.py - About 30 mins to fix

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        try:

            temp = response.split('|')

            # Parse out the ASN information.
Severity: Major
Found in ipwhois/asn.py and 3 other locations - About 30 mins to fix
ipwhois/asn.py on lines 141..168
ipwhois/asn.py on lines 198..225
ipwhois/asn.py on lines 331..382

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _parse(self):
        """
        The function for parsing the JSON response to the vars dictionary.
        """
Severity: Minor
Found in ipwhois/rdap.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function lookup_whois has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def lookup_whois(self, inc_raw=False, retry_count=3, get_referral=False,
                     extra_blacklist=None, ignore_referral_errors=False,
                     field_list=None, extra_org_map=None,
                     inc_nir=True, nir_field_list=None, asn_methods=None,
                     get_asn_description=True):
Severity: Minor
Found in ipwhois/ipwhois.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Do not use bare 'except'
Open

        except:  # pragma: no cover
Severity: Minor
Found in ipwhois/net.py by pep8

When catching exceptions, mention specific exceptions when possible.

Okay: except Exception:
Okay: except BaseException:
E722: except:
Severity
Category
Status
Source
Language