Sign upLogin

sedouard/azure-arm-validator

View on GitHub
Star

Showing 11 of 11 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  return mongoHelper.connect()
    .then(db => {
      var resourceGroups = db.collection('resourceGroups');
      var insert = RSVP.denodeify(resourceGroups.insert);
      return insert.call(resourceGroups, {
Severity: Major
Found in modules/azure.js and 1 other location - About 4 hrs to fix
modules/azure.js on lines 190..220

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 128.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  return mongoHelper.connect()
    .then(db => {
      var resourceGroups = db.collection('resourceGroups');
      var insert = RSVP.denodeify(resourceGroups.insert);
      return insert.call(resourceGroups, {
Severity: Major
Found in modules/azure.js and 1 other location - About 4 hrs to fix
modules/azure.js on lines 138..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 128.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (req.body.preReqTemplate) {
    promise = promise.then(() => {
      preReqFileName = tempDir + '/' + Guid.raw();
      preReqParametersFileName = tempDir + '/' + Guid.raw();
      return writeFileHelper(fs, preReqFileName, preReqParametersFileName, req.body.preReqTemplate, req.body.preReqParameters);
Severity: Major
Found in routes/validate.js and 1 other location - About 3 hrs to fix
routes/validate.js on lines 73..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (req.body.preReqTemplate) {
    promise = promise.then(() => {
      preReqFileName = tempDir + '/' + Guid.raw();
      preReqParametersFileName = tempDir + '/' + Guid.raw();
      return writeFileHelper(fs, preReqFileName, preReqParametersFileName, req.body.preReqTemplate, req.body.preReqParameters);
Severity: Major
Found in routes/validate.js and 1 other location - About 3 hrs to fix
routes/validate.js on lines 158..164

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (req.body.pull_request) {
    promise = promise
      .then(() => {
        return replaceRawLinksForPR(req.body.template, req.body.pull_request);
      })
Severity: Major
Found in routes/validate.js and 1 other location - About 3 hrs to fix
routes/validate.js on lines 146..156

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (req.body.pull_request) {
    promise = promise
      .then(() => {
        return replaceRawLinksForPR(req.body.template, req.body.pull_request);
      })
Severity: Major
Found in routes/validate.js and 1 other location - About 3 hrs to fix
routes/validate.js on lines 61..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function testTemplateWithPreReq has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.testTemplateWithPreReq = function (rgName, templateFile, parametersFile, preReqTemplateFile, preReqParametersFile) {
  debug('DEBUG: using prereq template file:');
  debug(preReqTemplateFile);
  debug('using prereq template parameters:');
  debug(preReqParametersFile);
Severity: Major
Found in modules/azure.js - About 2 hrs to fix

    Function testTemplate has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.testTemplate = function (rgName, templateFile, parametersFile, templateLink) {
  debug('DEBUG: using template file:');
  debug(templateFile);
  debug('using paramters:');
  debug(parametersFile);
    Severity: Minor
    Found in modules/azure.js - About 1 hr to fix

      Function replaceKeyParameters has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.replaceKeyParameters = function (parameters) {
  var parametersString = JSON.stringify(parameters);
  // for unique parameters replace each with a guid
  var matches = parametersString.match(new RegExp(conf.get('PARAM_REPLACE_INDICATOR') + '-\\d+', 'g'));
  if (matches) {
      Severity: Minor
      Found in modules/param_helper.js - About 1 hr to fix

        Function writeFileHelper has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function writeFileHelper(fs, fileName, parametersFileName, template, parameters) {
        Severity: Minor
        Found in routes/validate.js - About 35 mins to fix

          Function testTemplateWithPreReq has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          exports.testTemplateWithPreReq = function (rgName, templateFile, parametersFile, preReqTemplateFile, preReqParametersFile) {
          Severity: Minor
          Found in modules/azure.js - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language