sedouard/azure-arm-validator

View on GitHub

Showing 5 of 11 total issues

Function testTemplateWithPreReq has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.testTemplateWithPreReq = function (rgName, templateFile, parametersFile, preReqTemplateFile, preReqParametersFile) {
  debug('DEBUG: using prereq template file:');
  debug(preReqTemplateFile);
  debug('using prereq template parameters:');
  debug(preReqParametersFile);
Severity: Major
Found in modules/azure.js - About 2 hrs to fix

    Function testTemplate has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.testTemplate = function (rgName, templateFile, parametersFile, templateLink) {
      debug('DEBUG: using template file:');
      debug(templateFile);
      debug('using paramters:');
      debug(parametersFile);
    Severity: Minor
    Found in modules/azure.js - About 1 hr to fix

      Function replaceKeyParameters has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.replaceKeyParameters = function (parameters) {
        var parametersString = JSON.stringify(parameters);
        // for unique parameters replace each with a guid
        var matches = parametersString.match(new RegExp(conf.get('PARAM_REPLACE_INDICATOR') + '-\\d+', 'g'));
        if (matches) {
      Severity: Minor
      Found in modules/param_helper.js - About 1 hr to fix

        Function writeFileHelper has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function writeFileHelper(fs, fileName, parametersFileName, template, parameters) {
        Severity: Minor
        Found in routes/validate.js - About 35 mins to fix

          Function testTemplateWithPreReq has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          exports.testTemplateWithPreReq = function (rgName, templateFile, parametersFile, preReqTemplateFile, preReqParametersFile) {
          Severity: Minor
          Found in modules/azure.js - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language