Sign upLogin

seerline/clchart

View on GitHub
Star

Showing 392 of 392 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function _drawHline (context, xx1, xx2, yy) {
  context.moveTo(xx1, yy)
  context.lineTo(xx2, yy)
}
Severity: Minor
Found in src/util/cl.draw.js and 1 other location - About 30 mins to fix
src/util/cl.draw.js on lines 70..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      _drawTxt(this.context, xx, yy, value,
        this.text.font, this.text.pixel, clr,
        { x: posX, y: 'top' })
Severity: Minor
Found in src/chart/cl.draw.axisY.js and 2 other locations - About 30 mins to fix
src/chart/cl.draw.axisY.js on lines 107..109
src/chart/cl.draw.axisY.js on lines 133..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function initSystem has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function initSystem (cfg) {
  if (cfg === undefined) return
  for (const key in _systemInfo) {
    _systemInfo[key] = cfg[key] || _systemInfo[key]
  }
Severity: Minor
Found in src/chart/cl.chart.init.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mergeDay has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  mergeDay (source, now, rightMode) {
    let out = copyArrayOfDeep(source.value)
    if (now !== undefined && !checkZero(now.value, now.fields)) {
      const checked = findDateInDay(source, getDate(now.value[now.fields.time]))
      if (checked.finded) {
Severity: Minor
Found in src/data/cl.data.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function runSingleStock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  runSingleStock (source, formula) {
    // fix for Wechat mina do not support eval
    if (!eval) {
      const singleValue = []
      const matchData = formula.match(/\.(\w+)(\(.+)/)
Severity: Minor
Found in src/formula/cl.formula.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function intersectArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function intersectArray (a, b) {
  const result = []
  for (let ai = 0; ai < a.length; ai++) {
    for (let bi = 0; bi < b.length; bi++) {
      if (a[ai] === b[bi]) {
Severity: Minor
Found in src/util/cl.tool.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeMinute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  makeMinute (outkey, source, rightMode) {
    let out = []
    if (source !== undefined && !isEmptyArray(source.value)) {
      out = copyArrayOfDeep(source.value)
      if (this.InData['RIGHT'] !== undefined)
Severity: Minor
Found in src/data/cl.data.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _getTouchInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function _getTouchInfo (point, element) {
  const mouseInfo = {
    name: 'touch'
  }
  if (point.offsetX && point.offsetX === 0) {
Severity: Minor
Found in src/event/cl.event.handler.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function VEMA has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  VEMA (label, period) {
    let zoom = 1/period
    let off = 1
    let value = 0
    for (let m = 0; m < period; m++) {
Severity: Minor
Found in src/formula/cl.formula.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _drawTxtRect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function _drawTxtRect (context, xx, yy, txt, config) {
  const spaceX = config.spaceX || 2
  const spaceY = config.spaceY || 2
  const tr = __getTxtRect(context, txt, config)
Severity: Minor
Found in src/util/cl.draw.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onPaint has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  onPaint (key) {
    if (key !== undefined) this.hotKey = key
    this.data = this.source.getData(this.hotKey)

    const len = _getTxtWidth(this.context, '▲', this.symbol.font, this.symbol.pixel)
Severity: Minor
Found in src/chart/cl.draw.trade.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getExrightPriceRange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function getExrightPriceRange (start, stop, price, rights) {
  if (rights === undefined || rights.length < 1) return price
  let rightpara
  for (let j = 0; j < rights.length; j++) {
    if (rights[j][0] > start && rights[j][0] <= stop) {
Severity: Minor
Found in src/data/cl.data.tools.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language