Sign upLogin

seibii/container_ship

View on GitHub
Star

Showing 2 of 2 total issues

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def initialize(cluster_name, type, name, environment, build_number)
Severity: Minor
Found in lib/container_ship/task_definition.rb - About 35 mins to fix

    Method do_every_5_seconds has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def do_every_5_seconds(timeout: nil)
          timeout ||= 300 # default is 5 minutes
          start = Time.now
          loop do
            sleep 3
    Severity: Minor
    Found in lib/container_ship/command/modules/ecs.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language