Sign upLogin

seiyria/c

View on GitHub
Star

Showing 26 of 57 total issues

Function upgradeManager has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

var upgradeManager = function(GameState, UPGRADES, favico) {

  var hasUpgrade = function(key, level = 0) {
    return GameState.upgrade.has(key, level);
  };
Severity: Minor
Found in src/js/upgrademanager.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function gameState has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

var gameState = function($q, notificationService, $filter, UPGRADES, ACHIEVEMENTS, GainCalculator, localStorage, AnimatedFlyTip) {
Severity: Major
Found in src/js/gamestate.js - About 1 hr to fix

Function gameTimer has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

var gameTimer = function($q, $interval, $timeout, $window, GameState, AdManager, GainCalculator) {
Severity: Major
Found in src/js/gametimer.js - About 50 mins to fix

Function animatedFlyTip has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

var animatedFlyTip = function($filter) {
  return {
    fly: function(num, useSeparator = false) {
      var $element = $('<div />');
Severity: Minor
Found in src/js/animatedflytip.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function gameTimer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

var gameTimer = function($q, $interval, $timeout, $window, GameState, AdManager, GainCalculator) {

  var interval = null;
  var timerDefer = $q.defer();
Severity: Minor
Found in src/js/gametimer.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function gainCalculator has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

var gainCalculator = function() {

  var boost = (upgrade) => Math.max(1, Math.pow(upgrade.getKey('Basic Boost') || 0, 2)+1);

  var iteration = function(upgrade) {
Severity: Minor
Found in src/js/gaincalculator.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language