Sign upLogin

senecajs/seneca-entity-history

View on GitHub
Star

Showing 11 of 11 total issues

Function entity_history_msg has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function entity_history_msg(msg: {
  ent: {
    id: string
    base: string
    name: string
Severity: Major
Found in lib/entity_history_msg.ts - About 2 hrs to fix

    Function make_cmd_save_history_msg has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function make_cmd_save_history_msg(options: any) {
  return async function cmd_save_history(
    msg: {
      ent: {
        id: null | string
    Severity: Major
    Found in lib/make_cmd_save_history_msg.ts - About 2 hrs to fix

      Function cmd_save_history has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        return async function cmd_save_history(
    msg: {
      ent: {
        id: null | string
        entity$: string
      Severity: Major
      Found in lib/make_cmd_save_history_msg.ts - About 2 hrs to fix

        Function make_cmd_save_history_msg has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        export function make_cmd_save_history_msg(options: any) {
  return async function cmd_save_history(
    msg: {
      ent: {
        id: null | string
        Severity: Minor
        Found in lib/make_cmd_save_history_msg.ts - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            work.out.fields = [
      ...new Set(
        work.out.items
          .reduce((c: any[], item: any) =>
            (c.push(...item.fields), c), [])
        Severity: Major
        Found in lib/entity_history_msg.ts and 1 other location - About 1 hr to fix
        lib/entity_history_msg.ts on lines 97..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            work.out.changed = [
      ...new Set(
        work.out.items
          .reduce((c: any[], item: any) =>
            (c.push(...item.changed), c), [])
        Severity: Major
        Found in lib/entity_history_msg.ts and 1 other location - About 1 hr to fix
        lib/entity_history_msg.ts on lines 106..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function history has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async history(histspec: any) {
    let seneca = histspec.seneca
    let entmsg = histspec.entmsg
    let entout = histspec.entout
    let entprev = histspec.entprev
        Severity: Minor
        Found in lib/intern.ts - About 1 hr to fix

          Function entity_restore_msg has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export async function entity_restore_msg(msg: {
  ent: {
    id?: string
    ent_id?: string
    ver_id: string
          Severity: Minor
          Found in lib/entity_restore_msg.ts - About 1 hr to fix

            Function entity_history_msg has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            export async function entity_history_msg(msg: {
  ent: {
    id: string
    base: string
    name: string
            Severity: Minor
            Found in lib/entity_history_msg.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function entity_load_msg has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export async function entity_load_msg(msg: {
  ent: {
    // version id; if null, load current
    id?: string
    ver_id?: string
            Severity: Minor
            Found in lib/entity_load_msg.ts - About 1 hr to fix

              Function history has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                async history(histspec: any) {
    let seneca = histspec.seneca
    let entmsg = histspec.entmsg
    let entout = histspec.entout
    let entprev = histspec.entprev
              Severity: Minor
              Found in lib/intern.ts - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language