Sign upLogin

senecajs/seneca-eventbrite-provider

View on GitHub
Star

Showing 12 of 12 total issues

File entities.ts has 427 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { EntityMap } from './types';

const entities: EntityMap = {
  event: {
    actions: {
Severity: Minor
Found in src/entities.ts - About 6 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      ticket_group: {
    actions: {
      load: {
        request: {
          method: 'get',
    Severity: Major
    Found in src/entities.ts and 1 other location - About 4 hrs to fix
    src/entities.ts on lines 362..390

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      venue: {
    actions: {
      load: {
        request: {
          method: 'get',
    Severity: Major
    Found in src/entities.ts and 1 other location - About 4 hrs to fix
    src/entities.ts on lines 333..361

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function make_actions has 99 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function make_actions(action_data: ActionData) {
  const { req_fn, details } = action_data
  const { request, after, before } = details
  const { path } = request
    Severity: Major
    Found in src/make-actions.ts - About 3 hrs to fix

      Function make_actions has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      function make_actions(action_data: ActionData) {
  const { req_fn, details } = action_data
  const { request, after, before } = details
  const { path } = request
      Severity: Minor
      Found in src/make-actions.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function EventbriteProvider has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function EventbriteProvider(this: any, options: any) {
  const seneca: any = this

  let API_KEY = ''
      Severity: Major
      Found in src/eventbrite-provider.ts - About 2 hrs to fix

        Function EventbriteProvider has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        function EventbriteProvider(this: any, options: any) {
  const seneca: any = this

  let API_KEY = ''
        Severity: Minor
        Found in src/eventbrite-provider.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function save has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async function save(this:any, msg:any) {
    const { q, ent } = msg
    let body: Record<string, any> = {}

    const built_path = build_uri(path, ent)
        Severity: Minor
        Found in src/make-actions.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  after: [
          { on: 'outent', field: 'event_id', set: { query: 'event_id' } },
          { on: 'outent', field: 'ticket_class_id', set: { query: 'ticket_class_id' } }
        ]
          Severity: Minor
          Found in src/entities.ts and 1 other location - About 50 mins to fix
          src/entities.ts on lines 326..329

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  after: [
          { on: 'outent', field: 'event_id', set: { inent: 'event_id' } },
          { on: 'outent', field: 'ticket_class_id', set: { inent: 'ticket_class_id' } }
        ]
          Severity: Minor
          Found in src/entities.ts and 1 other location - About 50 mins to fix
          src/entities.ts on lines 299..302

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            function make_load(ent: EntData) {
    if(!ent.load.details) return false
    return make_actions(ent.load).load
  }
          Severity: Minor
          Found in src/eventbrite-provider.ts and 1 other location - About 35 mins to fix
          src/eventbrite-provider.ts on lines 36..39

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            function make_save(ent: EntData) {
    if(!ent.save.details) return false
    return make_actions(ent.save).save
  }
          Severity: Minor
          Found in src/eventbrite-provider.ts and 1 other location - About 35 mins to fix
          src/eventbrite-provider.ts on lines 31..34

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language