Sign upLogin

senecajs/seneca-gateway

View on GitHub
Star
src/gateway.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function gateway has 231 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

function gateway(this: any, options: GatewayOptions) {
  let seneca: any = this
  const root: any = seneca.root
  const tu: any = seneca.export('transport/utils')
Severity: Major
Found in src/gateway.ts - About 1 day to fix

    Function gateway has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
    Invalid

    function gateway(this: any, options: GatewayOptions) {
  let seneca: any = this
  const root: any = seneca.root
  const tu: any = seneca.export('transport/utils')
    Severity: Minor
    Found in src/gateway.ts - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handler has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

      async function handler(json: any, ctx?: any) {
    if (options.debug.log) {
      root.log.debug('gateway-handler-json', { json })
    }
    Severity: Major
    Found in src/gateway.ts - About 4 hrs to fix

      File gateway.ts has 302 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* Copyright © 2021-2023 Richard Rodger, MIT License. */


import Seneca from 'seneca'
      Severity: Minor
      Found in src/gateway.ts - About 3 hrs to fix

        Function prepare has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Invalid

          async function prepare(json: any, ctx: any) {
    let i, hookaction

    let custom: any = seneca.util.deep({}, options.custom)
    for (i = 0; i < hooks.custom.length; i++) {
        Severity: Minor
        Found in src/gateway.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Invalid

              for (i = 0; i < hooks.fixed.length; i++) {
      hookaction = hooks.fixed[i]
      if ('object' === typeof (hookaction)) {
        fixed = seneca.util.deep(fixed, hookaction)
      }
          Severity: Major
          Found in src/gateway.ts and 1 other location - About 2 hrs to fix
          src/gateway.ts on lines 320..328

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Invalid

              for (i = 0; i < hooks.custom.length; i++) {
      hookaction = hooks.custom[i]
      if ('object' === typeof (hookaction)) {
        custom = seneca.util.deep(custom, hookaction)
      }
          Severity: Major
          Found in src/gateway.ts and 1 other location - About 2 hrs to fix
          src/gateway.ts on lines 332..340

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status