Sign upLogin

senecajs/seneca-mail

View on GitHub
Star

Showing 4 of 5 total issues

Function mail has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

function mail(options) {
  var seneca = this
  var mailer

  // TODO seneca 4.x with embedded promisify should support this
Severity: Minor
Found in mail.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function send_mail has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async function send_mail(msg, meta) {
    // NOTE: rendering and merging are performed by implementing hook:render yourself
    var content = msg.content // content to merge
    var merge = msg.merge || {} // merge rules
Severity: Major
Found in mail.js - About 3 hrs to fix

    Function render has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        email_opts.render = async (view, content) => {
      var orig_code = view.split('/')[0]
      var part = view.split('/')[1]

      var code = null
    Severity: Minor
    Found in mail.js - About 1 hr to fix

      Function run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function run() {
  var si = await Seneca({ logger:'flat', log: 'debug', legacy: { transport: false } })
      .use('promisify')
      .use('..', {
        email: {
      Severity: Minor
      Found in trial/sendgrid.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language