Sign upLogin

senecajs/seneca-provider

View on GitHub
Star

Showing 17 of 17 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      return asyncLocalStorage.run(store, async () => {
        const res = await fetcher(url, postConfig)

        if (200 <= res.status && res.status < 300) {
          const json: any = await res.json()
Severity: Major
Found in src/provider.ts and 1 other location - About 1 day to fix
src/provider.ts on lines 286..308

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 215.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      return asyncLocalStorage.run(store, async () => {
        const res = await fetcher(url, deleteConfig)

        if (200 <= res.status && res.status < 300) {
          const json: any = await res.json()
Severity: Major
Found in src/provider.ts and 1 other location - About 1 day to fix
src/provider.ts on lines 245..268

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 215.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function provider has 225 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function provider(this: any, options: ProviderOptions) {
  const seneca = this
  const { deep } = seneca.util

  const injectVars = seneca.export('env/injectVars')
Severity: Major
Found in src/provider.ts - About 1 day to fix

    File provider.ts has 443 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* Copyright © 2022-2023 Richard Rodger, MIT License. */


// TODO: field manip utils:
// pick subsets, renames, ignore undefs, etc - see trello-provider for use case
    Severity: Minor
    Found in src/provider.ts - About 6 hrs to fix

      Function makeUtils has 133 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function makeUtils(utilopts: ProviderUtilityOptions) {
    // TODO: provider name for better errors

    utilopts.name = utilopts.name || ''
      Severity: Major
      Found in src/provider.ts - About 5 hrs to fix

        Function provider has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
        Open

        function provider(this: any, options: ProviderOptions) {
  const seneca = this
  const { deep } = seneca.util

  const injectVars = seneca.export('env/injectVars')
        Severity: Minor
        Found in src/provider.ts - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function FetchRetry has 114 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function FetchRetry(fetch: any, defaults?: any) {
  defaults = defaults || {};
  if (typeof fetch !== 'function') {
    throw new Error('fetch must be a function');
  }
        Severity: Major
        Found in src/provider.ts - About 4 hrs to fix

          Function FetchRetry has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
          Open

          function FetchRetry(fetch: any, defaults?: any) {
  defaults = defaults || {};
  if (typeof fetch !== 'function') {
    throw new Error('fetch must be a function');
  }
          Severity: Minor
          Found in src/provider.ts - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function fetchRetry has 90 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            return function fetchRetry(input: any, init: any) {
    var retries = defaults.retries;
    var retryDelay = defaults.retryDelay;
    var retryOn = defaults.retryOn;
          Severity: Major
          Found in src/provider.ts - About 3 hrs to fix

            Function wrappedFetch has 54 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  var wrappedFetch = function(attempt: number) {
        // As of node 18, this is no longer needed since node comes with native support for fetch:
        /* istanbul ignore next */
        var _input =
          typeof Request !== 'undefined' && input instanceof Request
            Severity: Major
            Found in src/provider.ts - About 2 hrs to fix

              Function post has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  async function post(url: string, config?: any) {
      const postConfig = deep(
        {
          method: 'post',
          headers: {
              Severity: Minor
              Found in src/provider.ts - About 1 hr to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    save: (seneca: any, cmdspec: any, entspec: any, spec: any, options: any) => {
      seneca.message(makePattern(cmdspec, entspec, spec, options),
        makeAction(cmdspec, entspec, spec))
    },
                Severity: Major
                Found in src/provider.ts and 3 other locations - About 1 hr to fix
                src/provider.ts on lines 107..110
                src/provider.ts on lines 112..115
                src/provider.ts on lines 122..125

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 60.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    load: (seneca: any, cmdspec: any, entspec: any, spec: any, options: any) => {
      seneca.message(makePattern(cmdspec, entspec, spec, options),
        makeAction(cmdspec, entspec, spec))
    },
                Severity: Major
                Found in src/provider.ts and 3 other locations - About 1 hr to fix
                src/provider.ts on lines 107..110
                src/provider.ts on lines 117..120
                src/provider.ts on lines 122..125

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 60.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    list: (seneca: any, cmdspec: any, entspec: any, spec: any, options: any) => {
      seneca.message(makePattern(cmdspec, entspec, spec, options),
        makeAction(cmdspec, entspec, spec))
    },
                Severity: Major
                Found in src/provider.ts and 3 other locations - About 1 hr to fix
                src/provider.ts on lines 112..115
                src/provider.ts on lines 117..120
                src/provider.ts on lines 122..125

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 60.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    remove: (seneca: any, cmdspec: any, entspec: any, spec: any, options: any) => {
      seneca.message(makePattern(cmdspec, entspec, spec, options),
        makeAction(cmdspec, entspec, spec))
    },
                Severity: Major
                Found in src/provider.ts and 3 other locations - About 1 hr to fix
                src/provider.ts on lines 107..110
                src/provider.ts on lines 112..115
                src/provider.ts on lines 117..120

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 60.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function deleteImpl has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    async function deleteImpl(url: string, config?: any) {
      const deleteConfig = deep(
        {
          method: 'delete',
          headers: {
                Severity: Minor
                Found in src/provider.ts - About 1 hr to fix

                  Function applyModifySpec has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function applyModifySpec(data: any, spec?: ModifySpec) {
  if (spec) {
    if (spec.field) {
      for (let field in spec.field) {
        let fieldSpec = spec.field[field]
                  Severity: Minor
                  Found in src/provider.ts - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language