Sign upLogin

senecajs/seneca-refer

View on GitHub
Star

Showing 8 of 11 total issues

Function refer has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
Open

function refer(this: any, options: ReferOptions) {
  const seneca: any = this

  const genToken = this.util.Nid(options.token)
  const genCode = this.util.Nid(options.code)
Severity: Minor
Found in src/refer.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File refer.ts has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* Copyright © 2022 Seneca Project Contributors, MIT License. */


type ReferOptions = {
  debug?: boolean
Severity: Minor
Found in src/refer.ts - About 5 hrs to fix

    Function msgAcceptEntry has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async function msgAcceptEntry(this: any, msg: any) {
    const seneca = this

    // If check=true, do not update occur
    let check = true === msg.check ? true : false
    Severity: Major
    Found in src/refer.ts - About 3 hrs to fix

      Function msgCreateEntry has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async function msgCreateEntry(this: any, msg: any) {
    const seneca = this

    // Sending user, not required
    let user_id = msg.user_id
      Severity: Major
      Found in src/refer.ts - About 2 hrs to fix

        Function msgLoadRules has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async function msgLoadRules(this: any, msg: any) {
    const seneca = this

    const rules = await seneca.entity('refer/rule').list$()
        Severity: Minor
        Found in src/refer.ts - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                return {
        ok: false,
        why: 'entry-limit',
        details: {
          limit: entry.limit,
          Severity: Major
          Found in src/refer.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return {
        ok: false,
        why: 'entry-used',
      }
            Severity: Major
            Found in src/refer.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return {
      ok: true,
      entry,
      occur, // NOTE: will be undef if check=true
    }
              Severity: Major
              Found in src/refer.ts - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language