Sign upLogin

senecajs/seneca-repl

View on GitHub
Star

Showing 13 of 27 total issues

File cmds.ts has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* Copyright © 2023-2024 Richard Rodger and other contributors, MIT License. */

import Hoek from '@hapi/hoek'
import JsonStringify from 'json-stringify-safe'
Severity: Minor
Found in src/cmds.ts - About 3 hrs to fix

    Function expr has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    function expr(spec, exprState) {
  exprState = exprState || { i: 0, val: undefined }
  let top = false

  if (null == exprState.tokens) {
    Severity: Minor
    Found in bin/seneca-repl-exec.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function DelegateCmd has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    const DelegateCmd: Cmd = (spec: CmdSpec) => {
  const { context, argstr, respond } = spec

  let args = context.seneca.util.Jsonic(argstr) || []
  args = Array.isArray(args) ? args : [args]
    Severity: Minor
    Found in src/cmds.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const HistoryCmd: Cmd = (spec: CmdSpec) => {
  const { context, respond } = spec
  return respond(null, context.history)
}
    Severity: Major
    Found in src/cmds.ts and 1 other location - About 1 hr to fix
    src/cmds.ts on lines 167..170

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const HelpCmd: Cmd = (spec: CmdSpec) => {
  const { context, respond } = spec
  return respond(null, context.cmdMap)
}
    Severity: Major
    Found in src/cmds.ts and 1 other location - About 1 hr to fix
    src/cmds.ts on lines 103..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid deeply nested control flow statements.
    Open

                    for (let i = 0; i < history.length; i++) {
                  if (history[i].includes(search)) {
                    if (0 === offset) {
                      state.connection.readline.write(
                        makesearchprompt(search) + history[i],
    Severity: Major
    Found in bin/seneca-repl-exec.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                    if (31 < cc || 8 === cc) {
                if (127 === cc || 8 === cc) {
                  // state.connection.search =
                  //  state.connection.search.substring(0,state.connection.search.length-1)
                  // state.connection.offset = 0
      Severity: Major
      Found in bin/seneca-repl-exec.js - About 45 mins to fix

        Avoid too many return statements within this function.
        Open

                return re
        Severity: Major
        Found in bin/seneca-repl-exec.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return JP(head)
          Severity: Major
          Found in bin/seneca-repl-exec.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return expr(exprState)
            Severity: Major
            Found in bin/seneca-repl-exec.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return expr(exprState)
              Severity: Major
              Found in bin/seneca-repl-exec.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  return exprState.val
                Severity: Major
                Found in bin/seneca-repl-exec.js - About 30 mins to fix

                  Function connect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function connect(spec) {
  let duplex = null
  let protocol = spec.url.protocol

  if ('telnet:' === protocol) {
                  Severity: Minor
                  Found in bin/seneca-repl-exec.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language