senseobservationsystems/commonsense-ruby-lib

View on GitHub
lib/cs/session.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Session has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Session
    attr_accessor :logger, :base_uri

    def initialize(opts={})
      options = {
Severity: Minor
Found in lib/cs/session.rb - About 3 hrs to fix

    Method execute has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def execute(type, path, body, headers, &block)
    Severity: Minor
    Found in lib/cs/session.rb - About 35 mins to fix

      Method retry_on_509 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def retry_on_509(&block)
            while true
              response = yield
              if response_code == 509
                waitfor = Random.new.rand(30..45)
      Severity: Minor
      Found in lib/cs/session.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status