Sign upLogin

sensu-plugins/sensu-plugins-aws

View on GitHub
Star
bin/check-cloudwatch-composite-metric.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method composite_check has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def composite_check
    numerator_metric_resp = get_metric(config[:numerator_metric_name])
    denominator_metric_resp = get_metric(config[:denominator_metric_name])

    ## If the numerator is empty, then we see if there is a default. If there is a default
Severity: Minor
Found in bin/check-cloudwatch-composite-metric.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method composite_check has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def composite_check
    numerator_metric_resp = get_metric(config[:numerator_metric_name])
    denominator_metric_resp = get_metric(config[:denominator_metric_name])

    ## If the numerator is empty, then we see if there is a default. If there is a default
Severity: Minor
Found in bin/check-cloudwatch-composite-metric.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

          return :warning,  "#{base_msg} threshold=#{config[:warning]}"
    Severity: Major
    Found in bin/check-cloudwatch-composite-metric.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return :unknown, "#{metric_desc}: denominator value is zero"
      Severity: Major
      Found in bin/check-cloudwatch-composite-metric.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return :critical, "#{base_msg} threshold=#{config[:critical]}"
        Severity: Major
        Found in bin/check-cloudwatch-composite-metric.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return :ok, "#{base_msg}, will alarm at #{threshold}"
          Severity: Major
          Found in bin/check-cloudwatch-composite-metric.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status