Sign upLogin

sensu-plugins/sensu-plugins-bluepill

View on GitHub
Star

Showing 4 of 4 total issues

Method run has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    # Check if Bluepill is installed
    `which bluepill`
    # #YELLOW
    unless $CHILD_STATUS.success?
Severity: Minor
Found in bin/check-bluepill-procs.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bluepill_application_status has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def bluepill_application_status(name)
    out = { name: [], ok: [], warn: [], crit: [], err: [] }
    app_status = `#{config[:sudo] ? 'sudo ' : nil }bluepill #{name} status 2<&1`
    name = 'Unknown' if name == ''
    out[:name] << name
Severity: Minor
Found in bin/check-bluepill-procs.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    # Check if Bluepill is installed
    `which bluepill`
    # #YELLOW
    unless $CHILD_STATUS.success?
Severity: Minor
Found in bin/check-bluepill-procs.rb - About 1 hr to fix

    Method bluepill_application_status has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def bluepill_application_status(name)
    out = { name: [], ok: [], warn: [], crit: [], err: [] }
    app_status = `#{config[:sudo] ? 'sudo ' : nil }bluepill #{name} status 2<&1`
    name = 'Unknown' if name == ''
    out[:name] << name
    Severity: Minor
    Found in bin/check-bluepill-procs.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language