sensu-plugins/sensu-plugins-cassandra

View on GitHub

Showing 10 of 10 total issues

Method parse_cfstats has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_cfstats
    def get_metric(string) # rubocop:disable Lint/NestedMethodDefinition
      string.strip!
      (metric, value) = string.split(': ')
      if metric.nil? || value.nil? # rubocop:disable Style/GuardClause
Severity: Minor
Found in bin/metrics-cassandra-graphite.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_info has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_info
    info = nodetool_cmd('info')
    # #YELLOW
    # TODO: come back and refactor me to be better
    info.each_line do |line| # rubocop:disable Metrics/BlockLength
Severity: Minor
Found in bin/metrics-cassandra-graphite.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if (m = line.match(/^Key Cache[^:]+: entries ([0-9]+), size ([-+]?[0-9]*\.?[0-9]+) ([KMGT]i?B|bytes), capacity ([-+]?[0-9]*\.?[0-9]+) ([KMGT]i?B|bytes), ([0-9]+) hits, ([0-9]+) requests, ([-+]?[0-9]*\.?[0-9]+) recent hit rate/)) # rubocop:disable Layout/LineLength
        output "#{config[:scheme]}.key_cache.size", convert_to_bytes(m[2], m[3]), @timestamp
        output "#{config[:scheme]}.key_cache.capacity", convert_to_bytes(m[4], m[5]), @timestamp
        output "#{config[:scheme]}.key_cache.hits", m[6], @timestamp
        output "#{config[:scheme]}.key_cache.requests", m[7], @timestamp
Severity: Major
Found in bin/metrics-cassandra-graphite.rb and 1 other location - About 1 hr to fix
bin/metrics-cassandra-graphite.rb on lines 245..250

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if (m = line.match(/^Row Cache[^:]+: entries ([0-9]+), size ([-+]?[0-9]*\.?[0-9]+) ([KMGT]i?B|bytes), capacity ([-+]?[0-9]*\.?[0-9]+) ([KMGT]i?B|bytes), ([0-9]+) hits, ([0-9]+) requests, ([-+]?[0-9]*\.?[0-9]+) recent hit rate/)) # rubocop:disable Layout/LineLength
        output "#{config[:scheme]}.row_cache.size", convert_to_bytes(m[2], m[3]), @timestamp
        output "#{config[:scheme]}.row_cache.capacity", convert_to_bytes(m[4], m[5]), @timestamp
        output "#{config[:scheme]}.row_cache.hits", m[6], @timestamp
        output "#{config[:scheme]}.row_cache.requests", m[7], @timestamp
Severity: Major
Found in bin/metrics-cassandra-graphite.rb and 1 other location - About 1 hr to fix
bin/metrics-cassandra-graphite.rb on lines 227..232

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method parse_info has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_info
    info = nodetool_cmd('info')
    # #YELLOW
    # TODO: come back and refactor me to be better
    info.each_line do |line| # rubocop:disable Metrics/BlockLength
Severity: Minor
Found in bin/metrics-cassandra-graphite.rb - About 1 hr to fix

    Method parse_cfstats has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def parse_cfstats
        def get_metric(string) # rubocop:disable Lint/NestedMethodDefinition
          string.strip!
          (metric, value) = string.split(': ')
          if metric.nil? || value.nil? # rubocop:disable Style/GuardClause
    Severity: Minor
    Found in bin/metrics-cassandra-graphite.rb - About 1 hr to fix

      Method run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
          out, rc = nodetool_cmd('describecluster')
          if rc != 0
            critical(out)
          end
      Severity: Minor
      Found in bin/check-cassandra-schema.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse_tpstats has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def parse_tpstats# rubocop:disable all
          tpstats = nodetool_cmd('tpstats')
          tpstats.each_line do |line|
            next if line =~ /^Pool Name/
            next if line =~ /^Message type/
      Severity: Minor
      Found in bin/metrics-cassandra-graphite.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if (m = line.match(/^Key Cache[^:]+: size ([0-9]+) \(bytes\), capacity ([0-9]+) \(bytes\), ([0-9]+) hits, ([0-9]+) requests/))
              output "#{config[:scheme]}.key_cache.size", m[1], @timestamp
              output "#{config[:scheme]}.key_cache.capacity", m[2], @timestamp
              output "#{config[:scheme]}.key_cache.hits", m[3], @timestamp
              output "#{config[:scheme]}.key_cache.requests", m[4], @timestamp
      Severity: Major
      Found in bin/metrics-cassandra-graphite.rb and 1 other location - About 1 hr to fix
      bin/metrics-cassandra-graphite.rb on lines 235..239

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if (m = line.match(/^Row Cache[^:]+: size ([0-9]+) \(bytes\), capacity ([0-9]+) \(bytes\), ([0-9]+) hits, ([0-9]+) requests/))
              output "#{config[:scheme]}.row_cache.size", m[1], @timestamp
              output "#{config[:scheme]}.row_cache.capacity", m[2], @timestamp
              output "#{config[:scheme]}.row_cache.hits", m[3], @timestamp
              output "#{config[:scheme]}.row_cache.requests", m[4], @timestamp
      Severity: Major
      Found in bin/metrics-cassandra-graphite.rb and 1 other location - About 1 hr to fix
      bin/metrics-cassandra-graphite.rb on lines 217..221

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language