Sign upLogin

sensu-plugins/sensu-plugins-consul

View on GitHub
Star
bin/check-consul-service-health.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    if config[:tags] && config[:all]
      critical 'Cannot specify --tags and --all simultaneously (Consul health/service/ versus health/state/).'
    end
Severity: Minor
Found in bin/check-consul-service-health.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method acquire_service_data has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def acquire_service_data
    if config[:tags] && config[:service]
      tags = config[:tags].split(',').to_set
      services = []
      Diplomat::Health.service(config[:service]).each do |s|
Severity: Minor
Found in bin/check-consul-service-health.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    if config[:tags] && config[:all]
      critical 'Cannot specify --tags and --all simultaneously (Consul health/service/ versus health/state/).'
    end
Severity: Minor
Found in bin/check-consul-service-health.rb - About 1 hr to fix

    Method acquire_service_data has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def acquire_service_data
    if config[:tags] && config[:service]
      tags = config[:tags].split(',').to_set
      services = []
      Diplomat::Health.service(config[:service]).each do |s|
    Severity: Minor
    Found in bin/check-consul-service-health.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status