Sign upLogin

sensu-plugins/sensu-plugins-couchbase

View on GitHub
Star

Showing 23 of 23 total issues

File metrics-couchbase.py has 366 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
#
#   metrics-couchbase.py
#
# DESCRIPTION:
Severity: Minor
Found in bin/metrics-couchbase.py - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      try:
    query = 'http://%s:%s/pools/default/buckets' % (couchbase_host,
        couchbase_rest_port)
    response = requests.get(query, auth=(user, password))
    data = response.json()
    Severity: Major
    Found in bin/metrics-couchbase.py and 1 other location - About 4 hrs to fix
    bin/metrics-couchbase.py on lines 213..220

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      try:
    query = 'http://%s:%s/pools/default' % (couchbase_host, couchbase_rest_port)
    response = requests.get(query, auth=(user, password))
    data = response.json()
  except Exception as e:
    Severity: Major
    Found in bin/metrics-couchbase.py and 1 other location - About 4 hrs to fix
    bin/metrics-couchbase.py on lines 196..204

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function graphite_printer has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    def graphite_printer(all_stats, date, scheme, host_format=False):
  '''Takes a dict with stats_compute func structure flattens it for Graphite
  plain text protocol'''

  for host in all_stats:
    Severity: Minor
    Found in bin/metrics-couchbase.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        begin
      resource = '/pools/default/buckets'
      response = RestClient::Request.new(
        method: :get,
        url: "#{config[:api]}/#{resource}",
    Severity: Major
    Found in bin/check-couchbase-bucket-replica.rb and 1 other location - About 2 hrs to fix
    bin/check-couchbase-bucket-quota.rb on lines 76..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        begin
      resource = '/pools/default/buckets'
      response = RestClient::Request.new(
        method: :get,
        url: "#{config[:api]}/#{resource}",
    Severity: Major
    Found in bin/check-couchbase-bucket-quota.rb and 1 other location - About 2 hrs to fix
    bin/check-couchbase-bucket-replica.rb on lines 69..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function urls_generator has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    def urls_generator(couchbase_host, couchbase_rest_port, buckets,
    couchbase_nodes, logger, bucket_format=False):
  # This hits the same host to get all the stats but it can be changed to
  # hit each Couchbase node host for the per node stats
  '''Generate URLs from buckets and nodes to hit Couchbase REST API
    Severity: Minor
    Found in bin/metrics-couchbase.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function stats_compute has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    def stats_compute(hosts_buckets_urls, stats_names, write_stats, user,
    password, cutoff, logger):
  hosts_buckets_stats = {}
  hosts_buckets_write_stats = {}
  for host_bucket_url in hosts_buckets_urls:
    Severity: Minor
    Found in bin/metrics-couchbase.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    begin
      resource = '/pools/default/buckets'
      response = RestClient::Request.new(
        method: :get,
    Severity: Minor
    Found in bin/check-couchbase-bucket-quota.rb - About 1 hr to fix

      Function main has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def main():
  parser = optparse.OptionParser()

  parser.add_option('-c', '--couchbase-host',
    help     = 'Couchbase metrics source host',
      Severity: Minor
      Found in bin/metrics-couchbase.py - About 1 hr to fix

        Method run has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def run
    begin
      resource = '/pools/nodes'
      response = RestClient::Request.execute(
        method: :get,
        Severity: Minor
        Found in bin/check-couchbase-cluster.rb - About 1 hr to fix

          Method run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def run
    begin
      resource = '/pools/default/buckets'
      response = RestClient::Request.new(
        method: :get,
          Severity: Minor
          Found in bin/check-couchbase-bucket-quota.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def run
    begin
      resource = '/pools/default/buckets'
      response = RestClient::Request.new(
        method: :get,
          Severity: Minor
          Found in bin/check-couchbase-bucket-replica.rb - About 1 hr to fix

            Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def run
    begin
      resource = '/pools/nodes'
      response = RestClient::Request.execute(
        method: :get,
            Severity: Minor
            Found in bin/check-couchbase-cluster.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function stats_compute has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def stats_compute(hosts_buckets_urls, stats_names, write_stats, user,
            Severity: Major
            Found in bin/metrics-couchbase.py - About 50 mins to fix

              Function urls_generator has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def urls_generator(couchbase_host, couchbase_rest_port, buckets,
              Severity: Minor
              Found in bin/metrics-couchbase.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                          if host_formated == 'per_bucket':
            print "%s.%s.%s.%s.%s %s %d" % (scheme, host_formated, bucket,
                stat_name, stats, value, date)
          else:
            print "%s.per_bucket_per_node.%s.%s.%s.%s %s %d" % (scheme, host_formated, bucket,
                Severity: Major
                Found in bin/metrics-couchbase.py - About 45 mins to fix

                  Function get_nodes_in_cluster has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def get_nodes_in_cluster(couchbase_host, couchbase_rest_port, user, password,
                  Severity: Minor
                  Found in bin/metrics-couchbase.py - About 35 mins to fix

                    Function get_buckets has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def get_buckets(couchbase_host, couchbase_rest_port, user, password, logger):
                    Severity: Minor
                    Found in bin/metrics-couchbase.py - About 35 mins to fix

                      Function get_stats has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      def get_stats(url, user, password, cutoff, logger):
                      Severity: Minor
                      Found in bin/metrics-couchbase.py - About 35 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language