Sign upLogin

sensu-plugins/sensu-plugins-elasticsearch

View on GitHub
Star
bin/check-es-indices-sizes.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method build_indices_with_sizes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def build_indices_with_sizes
    indices_fs_stats = client.indices.stats store: true
    pattern_regex = Regexp.new(config[:pattern_regex])

    index_with_sizes = indices_fs_stats['indices'].keys.each_with_object({}) do |key, hash|
Severity: Minor
Found in bin/check-es-indices-sizes.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    node_fs_stats = client.nodes.stats metric: 'fs,indices'
    nodes_being_used = node_fs_stats['nodes'].values.select { |node| node['indices']['store']['size_in_bytes'] > 0 }

    # TODO: come back and cleanup all these rubocop disables with a little refactor
Severity: Minor
Found in bin/check-es-indices-sizes.rb - About 1 hr to fix

    Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    node_fs_stats = client.nodes.stats metric: 'fs,indices'
    nodes_being_used = node_fs_stats['nodes'].values.select { |node| node['indices']['store']['size_in_bytes'] > 0 }

    # TODO: come back and cleanup all these rubocop disables with a little refactor
    Severity: Minor
    Found in bin/check-es-indices-sizes.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status